Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist $HOME contents and move init to dockerfile #4

Merged
merged 7 commits into from
Jun 4, 2024

Conversation

axonasif
Copy link
Contributor

@axonasif axonasif commented Jun 3, 2024

@complyue
Copy link
Owner

complyue commented Jun 4, 2024

Thanks @axonasif !

It works pretty well after some tweaks now.

I wonder if axonasif/workspace-base is finding ways to gitpod/workspace-base? If that's the case I don't mind wait a while for the merge there, then incorporate the more "official" base image.

@axonasif
Copy link
Contributor Author

axonasif commented Jun 4, 2024

@complyue, it was proposed but I don't see any traction at the moment.
I've mentioned this in the dockerfile comments, here's the relevant issue: gitpod-io/workspace-images#1071

@complyue
Copy link
Owner

complyue commented Jun 4, 2024

Okay, I'm merging for now, then. Thanks again @axonasif !

@complyue complyue merged commit 42aa911 into complyue:master Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants