Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maybe I am lucky and it all works ;) #25

Closed
wants to merge 3 commits into from

Conversation

bgruening
Copy link

No description provided.

@bgruening
Copy link
Author

I updated the CI and improved a but the wrapper. However, its not working and I don't understand really why the Python wrapper is needed.

@Tomnl can you help here?

@Tomnl
Copy link
Member

Tomnl commented Apr 15, 2024

Hi @bgruening - thanks for this! I think there were some big changes in the CLI for SIRIUS v5.8.6 compared to v4.9.8 (Including permissions for how to connect to the CSI:FingerID online server) so expecting the version update to break a few things.

In terms of Python wrapper - originally that was just the easiest way to make sure the tool could be used with the MSP files generated as part of our annotation workflow - but arguably should be updated to use the SIRIUS CLI now without the Python wrapping.

@RJMW - was planning to do some work on this, so I think will pick this up soon

@bgruening
Copy link
Author

Cool, thanks! The current version is not working I think, as the server is not reachable anymore and we have now a few users that starts to nag us :)

Thanks for working on it, let us know if we can help.

@RJMW RJMW changed the base branch from main to v5.8.7+Galaxy0 July 9, 2024 11:42
@RJMW RJMW changed the base branch from v5.8.7+Galaxy0 to main July 9, 2024 11:44
@RJMW RJMW closed this Jul 9, 2024
@bgruening bgruening deleted the patch-1 branch July 9, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants