fix: removed data from config and add in data #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dainty-scone-61e301 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
prabhavpokharel
approved these changes
Oct 11, 2024
Contributor
prabhavpokharel
left a comment
prabhavpokharel
left a comment
There was a problem hiding this comment.
Looks good to me!
BISHALTWR
approved these changes
Oct 11, 2024
Contributor
BISHALTWR
left a comment
BISHALTWR
left a comment
There was a problem hiding this comment.
LGTM ... must have been a tedious task
gaurovgiri
requested changes
Oct 11, 2024
Contributor
gaurovgiri
left a comment
gaurovgiri
left a comment
There was a problem hiding this comment.
Can we merge this PR later? Also I have some suggestions:
- rename
tailwind-colorstocolors - after that, rather than using
{{ site.data.colors.bg-colors.___ }}, we can assign a variable eg.{% assign bg-colors = site.data.colors.bg-colors %}then just use{{ bg-colors.orange }}. This variable will be assigned inheader.htmlwhich ensures consistency across layouts.
Collaborator
|
@aayush105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #74
All the tailwind color are moved to the
data/tailwind-colors.ymlfile and also updated all the html files respectively with the value fromsite.bg-colors ->site.data.tailwind-colors.bg-colors.