Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magic_enum: add version 0.9.7 #25976

Merged
merged 2 commits into from
Nov 19, 2024
Merged

magic_enum: add version 0.9.7 #25976

merged 2 commits into from
Nov 19, 2024

Conversation

toge
Copy link
Contributor

@toge toge commented Nov 19, 2024

Summary

Changes to recipe: magic_enum/0.9.7

Motivation

There are several minor improvements in 0.9.7.

magic_enum.hpp include header has been replaced.
We have to include magic_enum/magic_enum.hpp.

Details

https://github.com/Neargye/magic_enum/releases/tag/v0.9.7
Neargye/magic_enum@v0.9.6...v0.9.7


@ErniGH ErniGH self-assigned this Nov 19, 2024
Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this to give us some time to investigate the back and forth as to what the location of the public header should be.

Please see #24894
and Neargye/magic_enum#310 (comment)

Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, indeed it has changed again

Neargye/magic_enum#374 (comment)

Thanks @toge! And thanks for waiting until a few days have passed since the releases are out :)

@jcar87 jcar87 merged commit 58e22c8 into conan-io:master Nov 19, 2024
8 checks passed
@gsantner
Copy link
Contributor

Hello,
wanted to ask if something went wrong with this package? Usually when PR is merged it's basically instant installable via conanfile. But this time only can install 0.9.6 and not found error on 0.9.7. However 0.9.7 is also listed at conan center as latest version. Not sure whats wrong?

@jcar87
Copy link
Contributor

jcar87 commented Nov 20, 2024

HI @gsantner - please be aware that since 4-nov-2024 we are uploading to a new Conan remote.

  • If you are using Conan 1.x - the repository at https://center.conan.io is no longer updated and is effectively in a frozen state
  • If you are using Conan 1.x - please update the remote to point to https://center2.conan.io - you can do this with
conan remote update conancenter --url https://center2.conan.io

More details:
#25461

@gsantner
Copy link
Contributor

gsantner commented Nov 20, 2024

Oh, thank you for the reply!
It is not really visible that there was this server change

@jcar87
Copy link
Contributor

jcar87 commented Nov 20, 2024

Oh, thank you for the reply! It is not really visible that there was this server change

Oh! Thanks for the feedback, we really tried to communicate it via all the channels possible.
On the Conan Center package browser at https://conan.io/center/recipes/magic_enum?version=0.9.7 there's also a banner at the top - perhaps we need to make it more noticeable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants