Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always quote raw args in docker runner #17002

Draft
wants to merge 4 commits into
base: develop2
Choose a base branch
from
Draft

Always quote raw args in docker runner #17002

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc930cc
Always quote raw args
AbrilRBS Sep 16, 2024
fa67e79
Merge branch 'develop2' into ar/quote-runner-docker-spaces
AbrilRBS Oct 8, 2024
3b33ac3
Merge branch 'develop2' into ar/quote-runner-docker-spaces
AbrilRBS Dec 2, 2024
0c4c10b
Breaking test
AbrilRBS Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conan/internal/runner/docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def __init__(self, conan_api, command, host_profile, build_profile, args, raw_ar

# Update conan command and some paths to run inside the container
raw_args[raw_args.index(args.path)] = self.abs_docker_path
self.command = ' '.join([f'conan {command}'] + [f'"{raw_arg}"' if ' ' in raw_arg else raw_arg for raw_arg in raw_args] + ['-f json > create.json'])
self.command = ' '.join([f'conan {command}'] + [f'"{raw_arg}"' for raw_arg in raw_args] + ['-f json > create.json'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it might be difficult, but it would be great to have some test that covers this, to guarantee it doesn't break in the future.


def run(self):
"""
Expand Down
Loading