Keep sessions around between each ConanRequester

conan/api/conan_api.py

@@ -41,9 +41,10 @@ def __init__(self, cache_folder=None):
         migrator = ClientMigrator(self.cache_folder, conan_version)
         migrator.migrate()
 
-        self.command = CommandAPI(self)
+        self.config = ConfigAPI(self)
         self.remotes = RemotesAPI(self)
-        # Search recipes by wildcard and packages filtering by configuracion
+        self.command = CommandAPI(self)
+        # Search recipes by wildcard and packages filtering by configuration
         self.search = SearchAPI(self)
         # Get latest refs and list refs of recipes and packages
         self.list = ListAPI(self)
@@ -52,7 +53,6 @@ def __init__(self, cache_folder=None):
         self.graph = GraphAPI(self)
         self.export = ExportAPI(self)
         self.remove = RemoveAPI(self)
-        self.config = ConfigAPI(self)
         self.new = NewAPI(self)
         self.upload = UploadAPI(self)
         self.download = DownloadAPI(self)

conan/api/subapi/remotes.py

@@ -7,6 +7,7 @@
 from conan.api.output import ConanOutput
 from conan.internal.cache.home_paths import HomePaths
 from conan.internal.conan_app import ConanApp
+from conans.client.rest.conan_requester import ConanRequester
 from conans.client.rest_client_local_recipe_index import add_local_recipes_index_remote, \
     remove_local_recipes_index_remote
 from conan.internal.api.remotes.localdb import LocalDB
@@ -31,6 +32,8 @@ def __init__(self, conan_api):
         self.conan_api = conan_api
         self._home_folder = conan_api.home_folder
         self._remotes_file = HomePaths(self._home_folder).remotes_path
+        # Wraps an http_requester to inject proxies, certs, etc
+        self._requester = ConanRequester(self.conan_api.config.global_conf, self.conan_api.cache_folder)
 
     def list(self, pattern=None, only_enabled=True):
         """

conan/internal/conan_app.py

@@ -46,9 +46,8 @@ def __init__(self, conan_api):
         cache_folder = conan_api.home_folder
         self.cache_folder = cache_folder
         self.cache = PkgCache(self.cache_folder, global_conf)
-
-        # Wraps an http_requester to inject proxies, certs, etc
-        self.requester = ConanRequester(global_conf, cache_folder)
+        # FIXME: ugly private access
+        self.requester = conan_api.remotes._requester
         # To handle remote connections
         # Wraps RestApiClient to add authentication support (same interface)
         localdb = LocalDB(cache_folder)

conan/test/utils/tools.py

@@ -277,6 +277,16 @@ def _set_auth_headers(kwargs):
                 kwargs["headers"] = {}
             kwargs["headers"].update(mock_request.headers)
 
+    def mount(self, *args, **kwargs):
+        pass
+
+    def Session(self):
+        return self
+
+    @property
+    def codes(self):
+        return requests.codes
+
 
 class TestServer(object):
     def __init__(self, read_permissions=None,

conans/client/rest/conan_requester.py

@@ -99,18 +99,12 @@ def add_auth(self, url, kwargs):
 class ConanRequester:
 
     def __init__(self, config, cache_folder=None):
-        # TODO: Make all this lazy, to avoid fully configuring Requester, for every api call
-        #  even if it doesn't use it
-        # FIXME: Trick for testing when requests is mocked
-        if hasattr(requests, "Session"):
-            self._http_requester = requests.Session()
-            adapter = HTTPAdapter(max_retries=self._get_retries(config))
-            self._http_requester.mount("http://", adapter)
-            self._http_requester.mount("https://", adapter)
-        else:
-            self._http_requester = requests
-
         self._url_creds = _SourceURLCredentials(cache_folder)
+        self._max_retries = config.get("core.net.http:max_retries", default=2, check_type=int)
+        self._http_requester = requests.Session()
+        _adapter = HTTPAdapter(max_retries=self._get_retries())
+        self._http_requester.mount("http://", _adapter)
+        self._http_requester.mount("https://", _adapter)
         self._timeout = config.get("core.net.http:timeout", default=DEFAULT_TIMEOUT)
         self._no_proxy_match = config.get("core.net.http:no_proxy_match", check_type=list)
         self._proxies = config.get("core.net.http:proxies")
@@ -123,9 +117,8 @@ def __init__(self, config, cache_folder=None):
                                    platform.machine()])
         self._user_agent = "Conan/%s (%s)" % (__version__, platform_info)
 
-    @staticmethod
-    def _get_retries(config):
-        retry = config.get("core.net.http:max_retries", default=2, check_type=int)
+    def _get_retries(self):
+        retry = self._max_retries
         if retry == 0:
             return 0
         retry_status_code_set = {

test/integration/command/remote_verify_ssl_test.py

@@ -1,5 +1,6 @@
 import unittest
 
+import requests
 from requests.models import Response
 
 from conan.test.utils.tools import TestClient
@@ -19,6 +20,15 @@ def get(self, url, *args, **kwargs):
         assert "cacert.pem" in kwargs["verify"], "TEST FAILURE: cacert.pem not in verify kwarg"
         return resp
 
+    def Session(self):
+        return self
+
+    @property
+    def codes(self):
+        return requests.codes
+
+    def mount(self, *args, **kwargs):
+        pass
 
 class RequesterMockFalse(object):
 
@@ -29,6 +39,16 @@ def get(self, url, *args, **kwargs):
         assert kwargs["verify"] is False, "TEST FAILURE: verify arg is not False"
         return resp
 
+    def Session(self):
+        return self
+
+    @property
+    def codes(self):
+        return requests.codes
+
+    def mount(self, *args, **kwargs):
+        pass
+
 
 class VerifySSLTest(unittest.TestCase):
 

test/integration/command/remove_test.py

@@ -356,9 +356,9 @@ def test_package_query_no_package_ref(populated_client):
 
 def _get_all_packages(client, ref, with_remote):
     ref = RecipeReference.loads(ref)
-    api = ConanAPI(client.cache_folder)
-    remote = api.remotes.get("default") if with_remote else None
     with client.mocked_servers():
+        api = ConanAPI(client.cache_folder)
+        remote = api.remotes.get("default") if with_remote else None
         try:
             return set([r.repr_notime() for r in api.list.packages_configurations(ref, remote=remote)])
         except NotFoundException:
@@ -367,9 +367,9 @@ def _get_all_packages(client, ref, with_remote):
 
 def _get_revisions_recipes(client, ref, with_remote):
     ref = RecipeReference.loads(ref)
-    api = ConanAPI(client.cache_folder)
-    remote = api.remotes.get("default") if with_remote else None
     with client.mocked_servers():
+        api = ConanAPI(client.cache_folder)
+        remote = api.remotes.get("default") if with_remote else None
         try:
             return set([r.repr_notime() for r in api.list.recipe_revisions(ref, remote=remote)])
         except NotFoundException:
@@ -378,9 +378,9 @@ def _get_revisions_recipes(client, ref, with_remote):
 
 def _get_revisions_packages(client, pref, with_remote):
     pref = PkgReference.loads(pref)
-    api = ConanAPI(client.cache_folder)
-    remote = api.remotes.get("default") if with_remote else None
     with client.mocked_servers():
+        api = ConanAPI(client.cache_folder)
+        remote = api.remotes.get("default") if with_remote else None
         try:
             return set([r.repr_notime() for r in api.list.package_revisions(pref, remote=remote)])
         except NotFoundException:

test/integration/conan_api/search_test.py

@@ -24,11 +24,11 @@ def test_search_recipes(remote_name):
 
     client.run("upload * -r=default -c")
 
-    # Search all the recipes locally and in the remote
-    api = ConanAPI(client.cache_folder)
-    remote = api.remotes.get(remote_name) if remote_name else None
-
     with client.mocked_servers():
+        # Search all the recipes locally and in the remote
+        api = ConanAPI(client.cache_folder)
+        remote = api.remotes.get(remote_name) if remote_name else None
+
         sot = api.search.recipes(query="f*", remote=remote)
         assert sot == [RecipeReference.loads("felipe/1.0"),
                        RecipeReference.loads("felipe/2.0"),