Add support for ECR public repository (public.ecr.aws) #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for Amazon ECR Public repositories to the registry-image-resource. Key changes include: - Skip authentication for public ECR repositories in check and in operations since they are publicly accessible - For out operations on public ECR, use AWS credentials but skip ECR token retrieval The implementation detects public ECR repositories by looking for "public.ecr.aws" in the repository string and applies different authentication logic based on the operation type. This enables Concourse pipelines to both pull from public ECR repositories without authentication and push to public ECR repositories with proper AWS credentials. Signed-off-by: Mathias Bogaert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for Amazon ECR Public repositories to the registry-image-resource. Key changes include:
The implementation detects public ECR repositories by looking for "public.ecr.aws" in the repository string and applies different authentication logic based on the operation type.
This enables Concourse pipelines to both pull from public ECR repositories without authentication and push to public ECR repositories with proper AWS credentials.
STILL TO BE TESTED