Skip to content

Conversation

@regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/20555223362 - please use this URL for debugging.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 28, 2025

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@lucascolley
Copy link
Member

@conda-forge/help-nodejs any idea what might be causing this failure?

npm ERR! Cannot read property '@detachhead/ts-helpers' of undefined

I see nothing that looks relevant in DetachHead/basedpyright@v1.36.1...v1.36.2.

@DetachHead
Copy link

hmm it could possibly be caused by DetachHead/basedpyright@9c29561 where the pinned nodejs-wheel dev dependency was bumped from v22 to 24. does conda-forge not work on newer node versions? does it currently use basedpyright's pinned version of nodejs-wheel? should it be?

@lucascolley
Copy link
Member

lucascolley commented Dec 29, 2025

The build log shows

 │ │ │ nodejs             ┆ 12.4.0     ┆ he1b5a44_0           ┆ conda-forge ┆   18.09 MiB │
 │ │ │ nodejs-wheel       ┆ 24.12.0    ┆ pyhd8ed1ab_0         ┆ conda-forge ┆   12.13 KiB │

@lucascolley
Copy link
Member

Hey @njzjz, any ideas?

@DetachHead
Copy link

do we know which of those it's using? i can try pinning nodejs-wheel to <24 to see if that fixes it. is it possible to test the change without me having to do a basedpyright release?

@lucascolley
Copy link
Member

We can make patches like https://rattler-build.prefix.dev/v0.55.0/create_patch/

@DetachHead
Copy link

i've made the changes in DetachHead/basedpyright#1690. if that does fix the issue, could you also please test with just the first commit as well

@lucascolley
Copy link
Member

If that is part of the fix then I assume we will want to pin nodejs-wheel in the recipe requirements too

@lucascolley
Copy link
Member

lucascolley commented Dec 29, 2025

We see the same failure trying to build 1.36.1 in gh-45, so it seems unrelated to any source code changes for 1.36.2. Let me try just pinning nodejs-wheel in the recipe

@lucascolley
Copy link
Member

hmm no, we see the same error with 22.20.0 for v1.36.1

 │ │ │ nodejs             ┆ 12.4.0     ┆ he1b5a44_0           ┆ conda-forge ┆   18.09 MiB │
 │ │ │ nodejs-wheel       ┆ 22.20.0    ┆ pyhd8ed1ab_0         ┆ conda-forge ┆   12.10 KiB │

@lucascolley
Copy link
Member

the last successful build of 1.36.1 used

 │ │ │ nodejs             ┆ 25.2.1     ┆ he2c55a7_1           ┆ conda-forge ┆   16.45 MiB │
 │ │ │ nodejs-wheel       ┆ 24.12.0    ┆ pyhd8ed1ab_0         ┆ conda-forge ┆   12.13 KiB │

so this may be related to some conda-forge nodejs change

@lucascolley
Copy link
Member

appears to be a solver quirk that nodejs 12.4.0 is getting picked up, adding nodejs >= 20 to both the host and run requirements seems to fix things.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

It appears that not all commits to this PR were made by the bot. Thus this PR is not being automatically merged. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@lucascolley lucascolley added the automerge Merge the PR when CI passes label Dec 29, 2025
@conda-forge-admin conda-forge-admin merged commit 570e0e6 into conda-forge:main Dec 29, 2025
4 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 1.36.2_h49be7b branch December 29, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the PR when CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants