Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for numpy 2.0 #60

Merged
merged 3 commits into from
May 2, 2024
Merged

Build for numpy 2.0 #60

merged 3 commits into from
May 2, 2024

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented May 1, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@h-vetinari
Copy link
Member

If you want, you could copy the migrators touched by conda-forge/conda-forge-pinning-feedstock#5790 into .ci_support/migrations with use_local: true and then rerender. I've done this in conda-forge/pythran-feedstock#84 and a couple other feedstocks, for example. Just if you want though. ;-)

@ocefpaf ocefpaf merged commit 7cfa8ba into conda-forge:dev May 2, 2024
31 checks passed
@ocefpaf ocefpaf deleted the np2 branch May 2, 2024 03:15
@trexfeathers
Copy link
Contributor

Many thanks @ocefpaf

@ocefpaf
Copy link
Member Author

ocefpaf commented May 2, 2024

@trexfeathers note that this is mostly for testing. I sent a PR upstream in SciTools/cf-units#427 and the relevant commit is SciTools/cf-units@7fbaeeb. Feel free to copy that over in a better PR if you want. Mine is a bit messy b/c I really cannot make heads or tails of the CI configuration there.

@trexfeathers
Copy link
Contributor

@ocefpaf OK, appreciate the clarification. Hopefully @bjlittle and @pp-mo (our current cf-units leads) will be able to find some time soon 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants