-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pixi
as an install tool
#2099
Conversation
pixi
as an install toolpixi
as an install tool
This is mostly functional. See last runs at conda-forge/dav1d-feedstock#21. It provisions the base environment in a similar way to what To note:
Anyway, fun stuff! The linux timings are impressive; around 10s thanks to the shared If this is considered for merge, I'd leave it as opt-in for now, so folks can experiment on their feedstocks and go back to conda-forge/staged-recipes#27754 is the equivalent PR in staged-recipes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The handling of local_ci_setup might be flawed right now IIUIC.
The current procedure on main installs the conda package, then force uninstalls it to leave the deps in the env, and then does the pip install without deps.
The code in this PR does a pip install on top of the conda package.
IDK if those two things are equivalent.
We should test this in the ci-setup feedstock.
Agreed, I haven't tested that, mostly left it there as a reminder of sorts. Worst case |
See conda-forge/conda-forge-ci-setup-feedstock#361 for ci-setup tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT to me assuming all of the feedstock tests work. I've been merging a bit fast I think since I've seen a few comments on PRs after I have merged them here. So i'll bump @conda-forge/core to look at this one too.
No probs, thank you for the reviews! I'm in no rush here, was just following the momentum of the micromamba changes because I had all that mental model in the "hot cache" part of my brain :P For those checking the PR now or later, this comment summarizes the changes: #2099 (comment). |
Haven't reviewed, but I think this is a great initiative and thanks a lot for pushing it forward. I checked out conda-forge/dav1d-feedstock#21 and I think it's really cool (aside from the speed gains) that with pixi tasks, we'll provide a much simplified interface for building things locally, e.g. |
Oooo... amazing! I love that re-rendering is now a task, too! |
@conda-forge/core it has been two weeks on this PR and there are no other reviews. Shall we merge? |
Checklist
news
entrypython conda_smithy/schema.py
)Only an experiment for now. Testing at conda-forge/dav1d-feedstock#21.
Will close conda-forge/conda-forge.github.io#2323.