Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add linux_aarch64 builds #14

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented Aug 21, 2023

Fixes #13

Adds linux_aarch64 builds to dgl.


Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #13.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

  • Bump the build number if needed.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

conda-forge-webservices[bot] and others added 2 commits August 21, 2023 22:53
@jakirkham jakirkham changed the title MNT: rerender Add linux_aarch64 builds Aug 21, 2023
@jakirkham
Copy link
Member

Looks like we still need a few more things before this is viable based on this error from CI (also here's the attached log):

The reported errors are:
- Encountered problems while solving:
-   - nothing provides requested pytorch * *cuda*
-   - nothing provides requested nanoflann
-   - nothing provides requested metis 5.1.1.*

@jakirkham jakirkham changed the title Add linux_aarch64 builds WIP: Add linux_aarch64 builds Aug 21, 2023
@jakirkham jakirkham marked this pull request as draft August 21, 2023 23:08
@mikemhenry
Copy link
Contributor

metis 5.1.1.*

I can work on getting that to build, last time I tried I got errors that didn't really make any sense

pytorch * cuda

We can get at least CPU support then

nanoflann

Looks like this just needs to be merged? conda-forge/nanoflann-feedstock#15

@jakirkham
Copy link
Member

Gotcha ok. Thanks for looking into it. Could you please link the PR once up and can take a look as well?

Yeah think CUDA ARM builds of PyTorch should be possible too. Originally the CUDA arch migrator waited for the arch migration to complete before starting a CUDA arch migration PR. There were issues with the PyTorch arch migration PR ( conda-forge/pytorch-cpu-feedstock#119 ) (particularly on linux_ppc64le), but linux_aarch64 builds were enabled as part of PR ( conda-forge/pytorch-cpu-feedstock#123 ). However as there is not much need for an additional CUDA arch migrator any more, the CUDA arch details were added to the global pinnings in PR ( conda-forge/conda-forge-pinning-feedstock#4733 ), which allows the regular arch migrator to enable CUDA builds. IOW just re-rendering should enable these CUDA arch builds for PyTorch

Thanks for the pointer! 🙏 Asked the team in PR ( conda-forge/nanoflann-feedstock#15 ) if they can take a look

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jaimergp
Copy link
Member

Synced with main to fetch the .ci_support/*yml stuff to do some debugging for #28

@jaimergp
Copy link
Member

jaimergp commented Feb 12, 2024

Hm, we need PyTorch + CUDA on linux-aarch64 for this to fully work with CUDA, and tensorflow for CPU builds:

@jakirkham
Copy link
Member

Yeah couldn't remember the current state. So wanted to retest

Probably still a bit more work before this becomes viable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-rerun Instruct the bot to retry the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling linux_aarch64 builds
4 participants