Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] build from main for testing flang-rt #80

Open
wants to merge 56 commits into
base: dev
Choose a base branch
from

Conversation

h-vetinari
Copy link
Member

For testing llvm/llvm-project#110217

Also remove the emscripten changes, which have been moved to a separate branch.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 6, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13019627161. Examine the logs at this URL for more detail.

@h-vetinari
Copy link
Member Author

@isuruf, could you PTAL here? This is for testing llvm/llvm-project#110217, which proposes to introduce flang-rt (similar relationship to flang as compiler-rt to clang).

This PR is just a POC to see how things would work together, but my idea would be to create a separate feedstock flang-rt after that upstream PR is merged. It would come after flang, but before flang-activation. I think it would also make sense to turn libflang into an alias for flang-rt, for continuity (at least for a couple releases).

Would appreciate your thoughts!

PS. Note that windows has no builds for now because upstream had a major build regression that killed builds for conda-forge/clangdev-feedstock#330 (& subsequent packages). This should hopefully be fixed soon-ish.

@h-vetinari h-vetinari marked this pull request as ready for review December 15, 2024 20:28
@h-vetinari h-vetinari requested a review from isuruf as a code owner December 15, 2024 20:28
@h-vetinari
Copy link
Member Author

Aside from some minor bugs (and shared runtime lib support on unix) still being worked out upstream, could you please let me know if you're alright with the approach structurally @isuruf?

(i.e. flang-rt being a separate feedstock depending on flang; the activation then depending on both)

@isuruf
Copy link
Member

isuruf commented Dec 26, 2024

Sounds good to me. We probably don't need to have a libflang->flang-rt redirection, because it looks like flang-rt is a colleciton of static libraries just like compiler-rt

@h-vetinari
Copy link
Member Author

h-vetinari commented Dec 26, 2024

Thanks for the response

it looks like flang-rt is a colleciton of static libraries just like compiler-rt

Shared support is being worked on upstream: llvm/llvm-project#120213

Shared libs on windows is still a bit further out, but should also follow. If we want to switch to the shared libs, then we'd switch on the run-export for flang-rt.

We probably don't need to have a libflang->flang-rt redirection

This was more from the POV that we've been producing packages (both with current and former flang) that have a run-dep on libflang, and I thought it might be prudent to avoid that the old builds gets coinstalled with flang-rt, by turning libflang into a wrapper around flang-rt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants