Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for fmt 11 and skip Windows' builds #222

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update fmt11.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/10580425710 - please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Rationale: Windows was never considered a supported platform of folly.
The maintainance of the feedstock for Windows is costly while the
use of it is questionable.

folly is used by a few projects on conda-forge, some of which
aren't distributed for Windows anyway.

See: https://github.com/facebook/folly?tab=readme-ov-file#build-notes
See: facebook/folly#962

Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Copy link
Member

@conda-forge-admin, please rerender

@jjerphan
Copy link
Member

@h-vetinari: I am proposing to skip the Windows' builds via 6b1187f (I can give more arguments if needed).

@h-vetinari
Copy link
Member

I think I saw you mention somewhere that windows isn't really supported by upstream folly anyway? I don't know the project well, so IMO fine to do that if that's what it takes.

I also checked mamba repoquery whoneeds -c conda-forge -p win-64 folly, and it seems that there are zero other packages depending on this on windows 🥳

@jjerphan
Copy link
Member

jjerphan commented Aug 28, 2024

I think I saw you mention somewhere that windows isn't really supported by upstream folly anyway? I don't know the project well, so IMO fine to do that if that's what it takes.

Yes, 6b1187f's commit message gives a few pointers (for instances see the build notes of folly, and facebook/folly#962 as one of several issues mentioning the non-official support of Windows).

I also checked mamba repoquery whoneeds -c conda-forge -p win-64 folly, and it seems that there are zero other packages depending on this on windows 🥳

Thanks! 🙏

Some packages depending on folly might be distributed for Windows as python wheels on PyPI but might fails to be distributed on conda-forge (this is the case of ArcticDB which has had problem with the unsane build of folly, see man-group/ArcticDB#449).


On a side-note, I guess we could also stop distributing new versions of folly on conda-forge due to the nature of the project (which have to pin it to a given version to have consistent state). See #185 for more context.

Anyway, if everything is good for you, I let you approve and merge this PR.

@h-vetinari
Copy link
Member

Anyway, if everything is good for you, I let you approve and merge this PR.

You are the maintainer here, not me. 😉

You have my LGTM!

Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving on with the decision to remove Windows builds, given the discussed elements in this thread and assuming future requests if any.

@jjerphan jjerphan changed the title Rebuild for fmt 11 Rebuild for fmt 11 and skip Windows' builds Aug 28, 2024
@jjerphan jjerphan merged commit 14464ec into conda-forge:main Aug 28, 2024
12 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-fmt11-0-1_h348ae2 branch August 28, 2024 08:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants