Build Matplotlib 3.9.0rc1 #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nda-forge-pinning 2023.03.04.06.16.51
…74b8f0 matplotlib v3.7.1
…nda-forge-pinning 2023.07.05.12.11.57
…fa7b62 matplotlib v3.7.2
…nda-forge-pinning 2023.09.11.19.37.56
3.7.3 he82bcd -Unpin Pyparsing
Matches changes in upstream with 3.8.0 final.
automerged PR by conda-forge/automerge-action
…nda-forge-pinning 2023.09.20.07.15.04
Reflect PSF-2.0 being an official SPDX license
…nda-forge-pinning 2023.10.10.09.57.53
automerged PR by conda-forge/automerge-action
automerged PR by conda-forge/automerge-action
…nda-forge-pinning 2023.11.17.15.21.27
jakirkham
reviewed
Jun 28, 2024
jakirkham
reviewed
Jun 28, 2024
…nda-forge-pinning 2024.06.28.09.32.10
…nda-forge-pinning 2024.06.28.09.32.10
TL;DR: The way we build against numpy has changed as of numpy 2.0. This bot
PR has updated the recipe to account for the changes (see below for details).
The biggest change is that we no longer need to use the oldest available numpy
version at build time in order to support old numpy version at runtime - numpy
will by default use a compatible ABI for the oldest still-supported numpy versions.
Additionally, we no longer need to use `{{ pin_compatible("numpy") }}` as a
run requirement - this has been handled for more than two years now by a
run-export on the numpy package itself. The migrator will therefore remove
any occurrences of this.
However, by default, building against numpy 2.0 will assume that the package
is compatible with numpy 2.0, which is not necessarily the case. You should
check that the upstream package explicitly supports numpy 2.0, otherwise you
need to add a `- numpy <2.0dev0` run requirement until that happens (check numpy
issue 26191 for an overview of the most important packages).
### To-Dos:
* [ ] Match run-requirements for numpy (i.e. check upstream `pyproject.toml` or however the project specifies numpy compatibility)
* If upstream is not yet compatible with numpy 2.0, add `numpy <2.0dev0` upper bound under `run:`.
* If upstream is already compatible with numpy 2.0, nothing else should be necessary in most cases.
* If upstream requires a minimum numpy version newer than 1.19, you can add `numpy >=x.y` under `run:`.
* [ ] Remove any remaining occurrences of `{{ pin_compatible("numpy") }}` that the bot may have missed.
PS. If the build does not compile anymore, this is almost certainly a sign that
the upstream project is not yet ready for numpy 2.0; do not close this PR until
a version compatible with numpy 2.0 has been released upstream and on this
feedstock (in the meantime, you can keep the bot from reopening this PR in
case of git conflicts by marking it as a draft).
…nda-forge-pinning 2024.06.28.09.32.10
…nda-forge-pinning 2024.06.28.09.32.10
…nda-forge-pinning 2024.06.28.09.32.10
jakirkham
reviewed
Jun 29, 2024
recipe/build_base.bat
Outdated
Comment on lines
5
to
23
| if "%CI%" == "azure" ( | ||
| :: Hack to try removing problematic Python from Azure CI image | ||
| :: Replace with conda-smithy solution when available | ||
| :: xref: https://github.com/conda-forge/conda-smithy/pull/1966 | ||
| set CLEANUP_DIRS=^ | ||
| C:\hostedtoolcache\windows\Python;^ | ||
| ; | ||
|
|
||
| %PYTHON% -m pip install --no-deps --no-build-isolation -vv . | ||
| mkdir C:\empty | ||
| for %%f in (%CLEANUP_DIRS:;= %) do ( | ||
| if not [%%f] == [] ( | ||
| echo Removing %%f | ||
| dir %%f | ||
| robocopy /purge /r:0 /w:0 /mt /ns /nc /np /nfl /ndl /njh /njs C:\empty %%f > nul 2>&1 | ||
| rmdir /q %%f | ||
| ) | ||
| ) | ||
| rmdir /q C:\empty | ||
| ) |
There was a problem hiding this comment.
Am planning to get this into conda-smithy ( conda-forge/conda-smithy#1966 )
However it is taking a bit longer to complete
So not to hold things up, have added similar logic here. With a note to follow up later
|
Ok all green 🥳 Please let me know if you need anything else here 🙂 |
|
Thanks Tom! 🙏 Looks like CI didn't start when this was merged. So have manually started it That said, it looks like this may run into the same failure you observed in comment: #390 (comment) |
|
The macOS and Windows builds passed Linux builds failed as expected Since this issue emerged, we have deployed a fix. So restarting failed builds to see if the remaining issues clear up |
|
All builds have now passed and uploaded packages |
|
Note that merging this PR into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)