-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dual protobuf #79
Dual protobuf #79
Conversation
…nda-forge-pinning 2024.03.11.20.30.53
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2024.03.11.23.14.35
…nda-forge-pinning 2024.03.11.23.14.35
…nda-forge-pinning 2024.03.12.00.50.18
…nda-forge-pinning 2024.03.12.02.51.02
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With static probobuf we had no such issues :D
Tell me about it….. |
anyway, i'm excited to see if we can get the openvino runtime working for onnxruntime. not sure if you have any interest in helping on that front!!!! (Thats my other plan for getting away from tensorflow) |
It's a good plan. I have a commit in conda-forge onnx runtime feedstock ilya-lavrenov/onnxruntime-feedstock@54134c1 which performs such integration. Do you think we don't need to wait for official ONNX RT releases and can use those patches? UPDATE: those changes are implemented when protobuf was used as a static library for OpenVINO, so we don't have any issues with compatibility of different protobuf versions |
Lets maybe discuss the static protobuf in the most problematic feedstock. Other feedstocks have been quite compatible with conda-forge's dynamic linking strategy so its hard to really point to specific problems that dynamic linking brings other than making it difficult to compile tensorflow.
I am much more inclined to merge in a patch that has been
This seems to hit all these points. There is no exact science, but if you are inclined you can try to see how well it applies to 1.17.1 and hopefully you won't have to do so much work. |
This would really be helpful for me.
See conda-forge/libprotobuf-feedstock#198 conda-forge/tensorflow-feedstock#378
needless to get my dual opencv builds up and running again:
conda-forge/opencv-feedstock#396
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)