Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCIP Optimization Suite 9.2.0 #77

Merged
merged 8 commits into from
Nov 18, 2024
Merged

SCIP Optimization Suite 9.2.0 #77

merged 8 commits into from
Nov 18, 2024

Conversation

scip-ci
Copy link
Contributor

@scip-ci scip-ci commented Nov 4, 2024

  • Update to SCIP Optimization Suite 9.2.0.
  • There is an issue with papilos cmake config (FindGMP.cmake not found in some environments), so a patch is added to work around this.
  • Fixed license info: ZIB Academic license is not longer used; fix Apache license identifier
  • Include papilo executable into papilo package, which comes with dependencies on scip and boost.
  • Add minimal test for papilo package.
  • SoPlex headers are C++14, so require that for the SoPlex example as well.

The conda-forge linter is now happy.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@scip-ci
Copy link
Contributor Author

scip-ci commented Nov 4, 2024

@discopt do you have a suggestion on the failing macOS and Windows jobs here?

The Windows build fails when the soplex package is tested with

CMake Error at D:/bld/scipoptsuite_1730731713063/_test_env/Library/share/cmake-3.30/Modules/CMakeFindDependencyMacro.cmake:76 (find_package):
  By not providing "FindGMP.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "GMP", but
  CMake did not find one.

  Could not find a package configuration file provided by "GMP" with any of
  the following names:

    GMPConfig.cmake
    gmp-config.cmake

  Add the installation prefix of "GMP" to CMAKE_PREFIX_PATH or set "GMP_DIR"
  to a directory containing one of the above files.  If "GMP" provides a
  separate development package or SDK, be sure it has been installed.

As far as I see, this is when the conda packages for both papilo and soplex are installed, and then it tries to build a SoPlex example using these packages.

It looks like the FindGMP.cmake should be there, because of line:

-- Installing: %PREFIX%\Library/lib/cmake/papilo/FindGMP.cmake

and the recipe saying this directory is to be included in the papilo package:

- "{{ install_prefix }}/lib/cmake/papilo/"

Do one need to set CMAKE_MODULE_PATH in addition?

On macOS, it seems to be the same problem.

@svigerske svigerske force-pushed the v920 branch 3 times, most recently from 0c1df78 to 23c8b71 Compare November 5, 2024 14:17
@scip-ci
Copy link
Contributor Author

scip-ci commented Nov 5, 2024

I give up here. Even when setting CMAKE_MODULE_PATH to a directory where FindGMP.cmake is located, cmake errors out with "By not providing "FindGMP.cmake" in CMAKE_MODULE_PATH this project has ..."

Changes by @discopt in PaPILO (scipopt/papilo@97bf10f) for SCIP OptSuite 9.2.0 are probably relevant why this comes up now, but it isn't clear what is wrong and I don't see a way to debug these conda builds properly (or why I should do it).
I will remove my test commits.

@discopt
Copy link

discopt commented Nov 6, 2024

I give up here. Even when setting CMAKE_MODULE_PATH to a directory where FindGMP.cmake is located, cmake errors out with "By not providing "FindGMP.cmake" in CMAKE_MODULE_PATH this project has ..."

Changes by @discopt in PaPILO (scipopt/papilo@97bf10f) for SCIP OptSuite 9.2.0 are probably relevant why this comes up now, but it isn't clear what is wrong and I don't see a way to debug these conda builds properly (or why I should do it). I will remove my test commits.

I added a MR in PaPILO (internal) and added you as a reviewer. So if you want you can give that a final try :-)

@scip-ci
Copy link
Contributor Author

scip-ci commented Nov 7, 2024

@discopt The issue with FindGMP.cmake seems to be fixed now. The osx_64 build runs find now.

On Windows, a new issue came up:

CMake Error at D:/bld/scipoptsuite_1730964543619/_test_env/Library/lib/cmake/Boost-1.72.0/BoostConfig.cmake:120 (find_package):
  Found package configuration file:

    D:/bld/scipoptsuite_1730964543619/_test_env/Library/lib/cmake/boost_iostreams-1.72.0/boost_iostreams-config.cmake

  but it set boost_iostreams_FOUND to FALSE so package "boost_iostreams" is
  considered to be NOT FOUND.  Reason given by package:
-- Configuring incomplete, errors occurred!

  No suitable build variant has been found.

  The following variants have been tried and rejected:

  * boost_iostreams.lib (shared, default on Windows is static, set
  Boost_USE_STATIC_LIBS=OFF to override)

The conda build for windows still uses old boost 1.72. #78 is trying to update on this, and removes Boost_USE_STATIC_LIBS=ON from the CMakeLists.txt's. So maybe that would help here, too.

@svigerske svigerske force-pushed the v920 branch 2 times, most recently from d2d1ee9 to 448f2cf Compare November 14, 2024 11:23
@conda-forge conda-forge deleted a comment from conda-forge-admin Nov 14, 2024
scip-ci and others added 7 commits November 15, 2024 10:45
- soon to be the minimum language for boost
- appends papilo cmake modules install path to CMAKE_MODULE_PATH
- the papilo executable makes use of scip and soplex, so add scip as run
  dependency of papilo (soplex should be statically linked)
- also need some boost libs to run papilo exe
- execute papilo executable
- test that papilo cmake and include are installed
@scip-ci
Copy link
Contributor Author

scip-ci commented Nov 15, 2024

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@scip-ci scip-ci marked this pull request as ready for review November 15, 2024 10:38
@scip-ci scip-ci requested a review from AntoinePrv as a code owner November 15, 2024 10:38
@scip-ci scip-ci merged commit 4c58409 into conda-forge:main Nov 18, 2024
7 checks passed
@scip-ci scip-ci deleted the v920 branch November 18, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants