Fix issue where retrieving menuinst version resulted in an error #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not check menuinst version for conda-based apps * Do not create shortcut if there is an error retrieving the menuinst version.
mrclary
requested review from
andfoy,
ccordoba12,
dalthviz and
steff456
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@ccordoba12 @dalthviz, we should be able to release a build-1 with this PR and then just try to re-run the failed jobs https://github.com/spyder-ide/spyder/actions/runs/11005699855/job/30559245423#step:14:835 |
|
Ok, sounds good to me. Thanks Ryan for your work on this. |
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Fixes spyder-ide/spyder#22566
Fixes spyder-ide/spyder#22565
menuinstversion for conda-based apps. This is not necessary and circumvents any inconsistencies withCONDA_PYTHON_EXEintroduced byconstructorat install time.menuinstversion. This should catch any error due toCONDA_PYTHON_EXEor ifmenuinstis not installed.