Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ultralytics package #22721

Merged
merged 1 commit into from
Jun 18, 2023
Merged

Add ultralytics package #22721

merged 1 commit into from
Jun 18, 2023

Conversation

abraha2d
Copy link
Contributor

@abraha2d abraha2d commented May 1, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ultralytics) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/ultralytics:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@abraha2d abraha2d changed the title Add ultralytics package Draft: Add ultralytics package May 1, 2023
@abraha2d abraha2d changed the title Draft: Add ultralytics package Add ultralytics package May 1, 2023
@abraha2d abraha2d marked this pull request as draft May 1, 2023 05:50
@abraha2d
Copy link
Contributor Author

abraha2d commented May 1, 2023

Blocked by getting thop onto conda-forge, which is blocked by Lyken17/pytorch-OpCounter#203.

@abraha2d
Copy link
Contributor Author

ultralytics 8.0.104 removes the dependency on thop, which unblocks this PR.

@abraha2d
Copy link
Contributor Author

abraha2d commented May 17, 2023

Windows build is failing due to missing pytorch packages (see conda-forge/pytorch-cpu-feedstock#32).
Ignoring as this is a noarch package, like #15917 (review)

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ultralytics) and found it was in an excellent condition.

@glenn-jocher
Copy link

Hi! Yes I confirm that I'm willing to be a maintainer for the ultralytics conda package.

@AyushExel please confirm as well

@AyushExel
Copy link

I confirm that I'm willing to be a maintainer of ultralytics package

@Laughing-q
Copy link

@abraha2d I confirm that I'm willing to be a maintainer of ultralytics package.

@glenn-jocher
Copy link

@abraha2d ok we're all confirmed as maintainers now!

@abraha2d abraha2d marked this pull request as ready for review May 26, 2023 15:42
@abraha2d
Copy link
Contributor Author

@conda-forge/help-python ready for review!

@glenn-jocher
Copy link

@conda-forge-admin this PR for Ultralytics YOLOv8 is all ready to merge!

@glenn-jocher
Copy link

@conda-forge-manager hi, this PR for Ultralytics YOLOv8 is all ready to merge!

@glenn-jocher
Copy link

@conda-forge/staged-recipes hi, this PR for Ultralytics YOLOv8 (https://github.com/ultralytics/ultralytics) is ready for review and merge.

Let us know if there are any changes required and we will implement them rapidly. Thank you!

@fcakyon
Copy link
Contributor

fcakyon commented Jun 18, 2023

@conda-forge/staged-recipes we are ready!

@ocefpaf ocefpaf merged commit 662d808 into conda-forge:main Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants