Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kantoku for BentoML Feedstock #28715

Merged
merged 15 commits into from
Jan 8, 2025
Merged

Add kantoku for BentoML Feedstock #28715

merged 15 commits into from
Jan 8, 2025

Conversation

rxm7706
Copy link
Contributor

@rxm7706 rxm7706 commented Dec 27, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 27, 2024

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12519766715. Examine the logs at this URL for more detail.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/kantoku/meta.yaml) and found it was in an excellent condition.

@rxm7706
Copy link
Contributor Author

rxm7706 commented Dec 27, 2024

@conda-forge/help-python, ready for review!
Windows failure is expected - as curses is not available for windows.

@ocefpaf
Copy link
Member

ocefpaf commented Jan 3, 2025

@conda-forge/help-python, ready for review! Windows failure is expected - as curses is not available for windows.

B/c there is no direct dependency on curses, this noarch package is installable, and broken, on Windows. You need to restrict its installation there with: https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-packages-with-os-specific-dependencies

You can do linux, and macOS noarch.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/kantoku/meta.yaml) and found some lint.

Here's what I've got...

For recipes/kantoku/meta.yaml:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12613832746. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/kantoku/meta.yaml) and found it was in an excellent condition.

Copy link
Contributor

github-actions bot commented Jan 4, 2025

Hi! This is the staged-recipes linter and I found some lint.

It looks like some changes were made outside the recipes/ directory. To ensure everything runs smoothly, please make sure that recipes are only added to the recipes/ directory and no other files are changed.

If these changes are intentional (and you aren't submitting a recipe), please add a maintenance label to the PR.

File-specific lints and/or hints:

  • conda-forge.yml:
    • lints:
      • Do not edit files outside of the recipes/ directory.

Copy link
Contributor

github-actions bot commented Jan 4, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@rxm7706
Copy link
Contributor Author

rxm7706 commented Jan 4, 2025

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/kantoku/meta.yaml) and found some lint.

Here's what I've got...

For recipes/kantoku/meta.yaml:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12613858964. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/kantoku/meta.yaml) and found it was in an excellent condition.

@rxm7706
Copy link
Contributor Author

rxm7706 commented Jan 4, 2025

@conda-forge-admin, please rerender

@rxm7706
Copy link
Contributor Author

rxm7706 commented Jan 4, 2025

@ocefpaf thank you - can you take another look now, and see if I have handled it correctly now.

@rxm7706
Copy link
Contributor Author

rxm7706 commented Jan 7, 2025

@conda-forge-admin, please rerender

@rxm7706
Copy link
Contributor Author

rxm7706 commented Jan 7, 2025

@conda-forge-admin, please rerender

@ocefpaf ocefpaf merged commit 14760aa into conda-forge:main Jan 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants