Skip to content

Add YAPSS to conda-forge#28720

Merged
xhochy merged 9 commits intoconda-forge:mainfrom
stevenrhall:add-yapss
Jan 23, 2025
Merged

Add YAPSS to conda-forge#28720
xhochy merged 9 commits intoconda-forge:mainfrom
stevenrhall:add-yapss

Conversation

@stevenrhall
Copy link
Copy Markdown
Contributor

@stevenrhall stevenrhall commented Dec 29, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@github-actions
Copy link
Copy Markdown
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent but I have some suggestions.

File-specific lints and/or hints:

  • recipes/yapss/meta.yaml:
    • hints:
      • It looks like you are submitting a multi-output recipe. In these cases, the correct name for the feedstock is ambiguous, and our infrastructure defaults to the top-level package.name field. Please add a feedstock-name entry in the extra section.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Dec 29, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/yapss/meta.yaml) and found some lint.

Here's what I've got...

For recipes/yapss/meta.yaml:

  • ❌ The home item is expected in the about section.
  • ❌ The license item is expected in the about section.
  • ❌ The summary item is expected in the about section.
  • ❌ There are too few lines. There should be one empty line at the end of the file.
  • requirements: host: python>=3.9,<3.14 must contain a space between the name and the pin, i.e. python >=3.9,<3.14
  • requirements: run: python>=3.9,<3.14 must contain a space between the name and the pin, i.e. python >=3.9,<3.14
  • requirements: run: casadi>=3.6.0 must contain a space between the name and the pin, i.e. casadi >=3.6.0

For recipes/yapss/meta.yaml:

  • ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.
  • ℹ️ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12532528708. Examine the logs at this URL for more detail.

@github-actions
Copy link
Copy Markdown
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/yapss/meta.yaml) and found it was in an excellent condition.

@stevenrhall
Copy link
Copy Markdown
Contributor Author

@conda-forge/help-python ready for review. I'm willing to be a maintainer.

@stevenrhall
Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please ping team

@conda-forge-webservices
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 7, 2025

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@stevenrhall
Copy link
Copy Markdown
Contributor Author

@conda-forge/help-python, ready for review.

Copy link
Copy Markdown
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits and force-push. Otherwise this will bloat the git repository.

Comment thread recipes/yapss/meta.yaml Outdated
Comment thread recipes/yapss/meta.yaml Outdated
Comment thread recipes/yapss/meta.yaml Outdated
@stevenrhall
Copy link
Copy Markdown
Contributor Author

Thank you, @xhochy. I've made the changes requested and all CI checks pass.

@stevenrhall stevenrhall requested a review from xhochy January 16, 2025 13:19
Comment thread recipes/yapss/meta.yaml Outdated
Comment thread recipes/yapss/meta.yaml Outdated
Comment thread recipes/yapss/meta.yaml
Comment thread recipes/yapss/meta.yaml Outdated
Comment thread recipes/yapss/meta.yaml
@github-actions
Copy link
Copy Markdown
Contributor

Hi! This is the staged-recipes linter and I found some lint.

It looks like some changes were made outside the recipes/ directory. To ensure everything runs smoothly, please make sure that recipes are only added to the recipes/ directory and no other files are changed.

If these changes are intentional (and you aren't submitting a recipe), please add a maintenance label to the PR.

File-specific lints and/or hints:

  • .scripts/run_osx_build.sh:
    • lints:
      • Do not edit files outside of the recipes/ directory.

@github-actions
Copy link
Copy Markdown
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@stevenrhall stevenrhall requested a review from xhochy January 20, 2025 14:35
@stevenrhall
Copy link
Copy Markdown
Contributor Author

Thanks for you help @xhochy. Should be ready now.

@xhochy xhochy merged commit 779f59d into conda-forge:main Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants