Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.18 remove libcuda.so from dependencies #418

Merged
merged 44 commits into from
Feb 9, 2025

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Feb 8, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Based on #414

regro-cf-autotick-bot and others added 30 commits October 25, 2024 04:08
jaxlib may need the same fix.
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 8, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13213134120. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • ❌ The feedstock has no .ci_support files and thus will not build any packages.

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13213158665. Examine the logs at this URL for more detail.

@njzjz njzjz force-pushed the remove-libcuda-deps branch from 5b758cd to 21ae777 Compare February 8, 2025 06:35
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 8, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13222667804. Examine the logs at this URL for more detail.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Feb 8, 2025

wow.

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👏

From my POV: let's remove the debugging left-overs, regenerate the matrix, and finally get this over the finish line.

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/conda_build_config.yaml Outdated Show resolved Hide resolved
@hmaarrfk
Copy link
Contributor

hmaarrfk commented Feb 9, 2025

@conda-forge-admin please rerender

conda-forge-webservices[bot] and others added 2 commits February 9, 2025 05:10
@njzjz njzjz force-pushed the remove-libcuda-deps branch from f5a2a4a to 266fcb8 Compare February 9, 2025 05:17
@h-vetinari
Copy link
Member

Given:

  • current resource congestion on the server
  • the fact that tensorflow v2.18.0 (redux) #414 already passed everywhere, and that this PR passed for one python version (with no reason to suspect divergence)

... I've cancelled all the current pytorch builds (the PRs needed yet another update anyway), and I'm going to merge this one right away. That way we can finally get 2.18 builds out the door, and we don't waste almost two full days of runtime on the server for it.

Thanks a lot for fixing the dependency on libcuda @njzjz! 🙏

@h-vetinari h-vetinari merged commit 98da479 into conda-forge:main Feb 9, 2025
3 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants