Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conda-store explanations #726

Merged
merged 16 commits into from
Jul 18, 2024

Conversation

pavithraes
Copy link
Member

@pavithraes pavithraes commented Jan 8, 2024

Addresses #748

Description

This pull request updates:

  • conda concepts
  • conda-store concepts
  • Artifacts
  • Performance impact

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)? -

Additional information

This PR needs some more work, but is ready for an initial review.

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for conda-store ready!

Name Link
🔨 Latest commit 90a9bdd
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/6699351d641c440008e94bd3
😎 Deploy Preview https://deploy-preview-726--conda-store.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Each individual user has a separate namespace, which has the same name as their username (used while logging in). All environments in this namespace are private to the individual.

A user can be a part of several other "shared" namespaces, and based on the level of access given to them, they can view and use the environment, edit the environment, or delete it all together. The permission are dictated by "role mappings".

## Role mappings
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

Copy link
Member Author

@pavithraes pavithraes Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peytondmurray - We can document the permissions for each role in this section

@pavithraes pavithraes marked this pull request as ready for review February 27, 2024 13:56
@peytondmurray
Copy link
Contributor

@pavithraes What's the status of this? Is there something I can do here to move this along? Those role permissions would be really nice to have.

@pavithraes
Copy link
Member Author

@peytondmurray I'd appreciate a review on this PR if you have time, and any notes on the role mapping (I'm not familiar with the recent updates, so any notes will be helpful to complete that section). This PR is mainly blocked on an initial review.

@peytondmurray
Copy link
Contributor

Here are the current role bindings:

    _viewer_permissions = {
        schema.Permissions.ENVIRONMENT_READ,
        schema.Permissions.NAMESPACE_READ,
        schema.Permissions.NAMESPACE_ROLE_MAPPING_READ,
    }
    _editor_permissions = {
        schema.Permissions.BUILD_CANCEL,
        schema.Permissions.ENVIRONMENT_CREATE,
        schema.Permissions.ENVIRONMENT_READ,
        schema.Permissions.ENVIRONMENT_UPDATE,
        schema.Permissions.ENVIRONMENT_SOLVE,
        schema.Permissions.NAMESPACE_READ,
        schema.Permissions.NAMESPACE_ROLE_MAPPING_READ,
        schema.Permissions.SETTING_READ,
    }
    _admin_permissions = {
        schema.Permissions.BUILD_DELETE,
        schema.Permissions.BUILD_CANCEL,
        schema.Permissions.ENVIRONMENT_CREATE,
        schema.Permissions.ENVIRONMENT_DELETE,
        schema.Permissions.ENVIRONMENT_READ,
        schema.Permissions.ENVIRONMENT_UPDATE,
        schema.Permissions.ENVIRONMENT_SOLVE,
        schema.Permissions.NAMESPACE_CREATE,
        schema.Permissions.NAMESPACE_DELETE,
        schema.Permissions.NAMESPACE_READ,
        schema.Permissions.NAMESPACE_UPDATE,
        schema.Permissions.NAMESPACE_ROLE_MAPPING_CREATE,
        schema.Permissions.NAMESPACE_ROLE_MAPPING_READ,
        schema.Permissions.NAMESPACE_ROLE_MAPPING_UPDATE,
        schema.Permissions.NAMESPACE_ROLE_MAPPING_DELETE,
        schema.Permissions.SETTING_READ,
        schema.Permissions.SETTING_UPDATE,
    }

docusaurus-docs/conda-store/explanations/artifacts.md Outdated Show resolved Hide resolved
docusaurus-docs/conda-store/explanations/artifacts.md Outdated Show resolved Hide resolved
docusaurus-docs/conda-store/explanations/artifacts.md Outdated Show resolved Hide resolved
docusaurus-docs/conda-store/explanations/artifacts.md Outdated Show resolved Hide resolved
docusaurus-docs/conda-store/explanations/artifacts.md Outdated Show resolved Hide resolved
docusaurus-docs/conda-store/explanations/conda-concepts.md Outdated Show resolved Hide resolved
docusaurus-docs/conda-store/explanations/conda-concepts.md Outdated Show resolved Hide resolved
@pavithraes
Copy link
Member Author

@peytondmurray Thanks for a thorough review, I've addressed and incorporated all your comments. :)

Signed-off-by: Pavithra Eswaramoorthy <[email protected]>
Signed-off-by: Pavithra Eswaramoorthy <[email protected]>
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the merge conflict! 🚢

@peytondmurray peytondmurray merged commit 94f7a26 into conda-incubator:main Jul 18, 2024
14 checks passed
@pavithraes pavithraes deleted the concepts branch September 16, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants