fix: allow DO_WHILE tasks with 'items' to pass validation without loopCondition#820
Open
nthmost-orkes wants to merge 11 commits intoconductor-oss:mainfrom
Open
Conversation
…pCondition When a DO_WHILE task uses list-iteration mode (items field set, or _items in inputParameters for Orkes compat), the executor auto-generates the loop condition. The validator was incorrectly requiring loopCondition in all cases, blocking workflow definitions that used the list-iteration feature. Fixes conductor-oss#819 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #819
WorkflowTaskTypeConstraint.WorkflowTaskValidatorunconditionally requiredloopConditionfor allDO_WHILEtasks. When using list-iteration mode (theitemsfield introduced in #624), the executor auto-generates the loop condition — users should not need to supply one. This prevented any workflow definition using list iteration from being saved.itemsis set (non-empty), skip theloopConditionrequirement_itemsis ininputParameters(Orkes compatibility), sameloopConditionas beforeloopOverremains required in all modesTest plan
testWorkflowTaskTypeDoWhile— existing test, verifies traditional mode still requires bothloopConditionandloopOvertestWorkflowTaskTypeDoWhileListIterationMode— new:itemsfield set, noloopCondition, expects 0 violationstestWorkflowTaskTypeDoWhileListIterationModeOrkesCompat— new:_itemsin inputParameters, noloopCondition, expects 0 violations./gradlew :conductor-core:test --tests "com.netflix.conductor.validations.WorkflowTaskTypeConstraintTest"🤖 Generated with Claude Code