Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: console prefix added to all resources #36

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

marnas
Copy link
Contributor

@marnas marnas commented Dec 9, 2024

All console resources have been renamed with a prefix of console_ for consistency and to allow resources with same name to also be defined for gateway client (e.g. conduktor_gateway_group_v2).

  • conduktor_user_v2  => conduktor_console_user_v2
  • conduktor_group_v2 => conduktor_console_group_v2
  • conduktor_kafka_cluster_v2 => conduktor_console_kafka_cluster_v2
  • conduktor_kafka_connect_v2 => conduktor_console_kafka_connect_v2

Order of the resources in provider_code_spec.json has also been updated alphabetically.

Copy link
Member

@qboileau qboileau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it not be better to move console models and resources into a separate console sub module ?
otherwise LGTM

@marnas marnas force-pushed the ops-599-prefix-console-resources branch 3 times, most recently from 3705641 to 794e323 Compare December 10, 2024 13:46
@marnas marnas force-pushed the ops-599-prefix-console-resources branch from 794e323 to 3de42f6 Compare December 10, 2024 14:22
@marnas marnas force-pushed the ops-599-prefix-console-resources branch from 3de42f6 to 5995ea2 Compare December 10, 2024 14:25
@marnas marnas merged commit 0652f12 into main Dec 10, 2024
11 checks passed
@marnas marnas deleted the ops-599-prefix-console-resources branch December 10, 2024 14:40
@qboileau qboileau added the enhancement New feature or request label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants