fix: handle missing types in CustomVulnerability init#207
Merged
A-Vamshi merged 1 commit intoconfident-ai:mainfrom Mar 23, 2026
Merged
Conversation
When CustomVulnerability is created without the types parameter, self.types was never set before being passed to super().__init__(), causing an AttributeError. This now defaults to a single type derived from the vulnerability name. Added tests for the no-types case and single-type case.
|
@frankentini is attempting to deploy a commit to the Confident AI Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Hey @frankentini, thanks for the PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
CustomVulnerabilityis initialized without thetypesparameter (which isOptional[List[str]]and defaults toNone), the constructor crashes with anAttributeErrorbecauseself.typesis only set inside theif types:block but is unconditionally accessed insuper().__init__(self.types).Fix
When
typesis not provided, default to a single-member enum derived from the vulnerability name. This ensuresself.typesis always iterable and the vulnerability can be used without explicitly listing types.Tests
Added test cases for:
typesparameterget_name()works without types