Skip to content

Commit

Permalink
Fix maxInitWaitTime tests by adding a bit of tolerance to timing checks
Browse files Browse the repository at this point in the history
  • Loading branch information
adams85 committed Nov 10, 2023
1 parent 8cc752e commit 477342c
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions test/ConfigCatClientTests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,7 @@ describe("ConfigCatClient", () => {
const actualValue = await client.getValueAsync("debug", false);
const elapsedMilliseconds: number = new Date().getTime() - startDate;

assert.isAtLeast(elapsedMilliseconds, maxInitWaitTimeSeconds * 1000);
assert.isAtLeast(elapsedMilliseconds, (maxInitWaitTimeSeconds * 1000) - 10); // 10 ms for tolerance
assert.isAtMost(elapsedMilliseconds, (maxInitWaitTimeSeconds * 1000) + 50); // 50 ms for tolerance
assert.equal(actualValue, false);
});
Expand Down Expand Up @@ -605,7 +605,7 @@ describe("ConfigCatClient", () => {
const state = await client.waitForReady();
const elapsedMilliseconds: number = new Date().getTime() - startDate;

assert.isAtLeast(elapsedMilliseconds, maxInitWaitTimeSeconds * 1000);
assert.isAtLeast(elapsedMilliseconds, (maxInitWaitTimeSeconds * 1000) - 10); // 10 ms for tolerance
assert.isAtMost(elapsedMilliseconds, (maxInitWaitTimeSeconds * 1000) + 50); // 50 ms for tolerance

assert.equal(state, ClientReadyState.NoFlagData);
Expand All @@ -631,7 +631,7 @@ describe("ConfigCatClient", () => {
const state = await client.waitForReady();
const elapsedMilliseconds: number = new Date().getTime() - startDate;

assert.isAtLeast(elapsedMilliseconds, maxInitWaitTimeSeconds * 1000);
assert.isAtLeast(elapsedMilliseconds, (maxInitWaitTimeSeconds * 1000) - 10); // 10 ms for tolerance
assert.isAtMost(elapsedMilliseconds, (maxInitWaitTimeSeconds * 1000) + 50); // 50 ms for tolerance

assert.equal(state, ClientReadyState.HasCachedFlagDataOnly);
Expand Down

0 comments on commit 477342c

Please sign in to comment.