Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit logic for ibc v3 gov updates #440

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Revisit logic for ibc v3 gov updates #440

wants to merge 2 commits into from
+46 −29

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Aug 12, 2022 •
edited
Loading

Part of #364

TODOs:

  • Upgrade contracts
  • Fix tests

alpe
alpe reviewed Aug 23, 2022
View reviewed changes
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start with the upgrade proposal type

alpe
alpe approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

alpe
alpe suggested changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, tests fail: https://app.circleci.com/pipelines/github/confio/tgrade/1140/workflows/a2a8d059-0069-47da-aed8-65e3d9af2990/jobs/4891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpe alpe alpe requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinosu @alpe