Cpbr 1867 ubi9 minimal #618
Conversation
cp-base-jre17/Dockerfile.ubi8
Outdated
| gpgkey=https://packages.adoptium.net/artifactory/api/gpg/key/public \n\ | ||
| " > /etc/yum.repos.d/adoptium.repo | ||
| RUN echo "installing temurin-17-jre:${TEMURIN_JDK_VERSION}" | ||
| RUN yum --nodocs install -y --setopt=install_weak_deps=False temurin-17-jre |
There was a problem hiding this comment.
we have to use JDK 21 with CP 8.0, let update it as part of this PR itself
cp-base-jre17/pom.xml
Outdated
|
|
||
| <packaging>pom</packaging> | ||
|
|
||
| <artifactId>cp-base-jre17</artifactId> |
There was a problem hiding this comment.
let's rename this image as cp-java21
base-java/Dockerfile.ubi8
Outdated
| @@ -0,0 +1,78 @@ | |||
| ARG MICRODIR=/microdir | |||
| ARG UBI_MICRO_VERSION=8.10-13 | |||
There was a problem hiding this comment.
please remove unused args in the Dockerfile
base-java/Dockerfile.ubi8
Outdated
| ARG MICRODIR=/microdir | ||
| ARG UBI_MICRO_VERSION=8.10-13 | ||
| ARG TEMURIN_JDK_VERSION="21.0.6.0.0.7-1" | ||
| ARG DOCKER_UPSTREAM_REGISTRY="519856050701.dkr.ecr.us-west-2.amazonaws.com/docker/prod/" |
There was a problem hiding this comment.
please remove default values for these args so that the build fails if the corrects args are not provided. This will ensure that args are properly propagated during docker build
base-java/Dockerfile.ubi8
Outdated
| # base image that supports it | ||
| ENV LANG="C.UTF-8" | ||
|
|
||
| #ARG MICRODIR |
There was a problem hiding this comment.
please remove this commented line
| RUN go test ./... | ||
|
|
||
| FROM registry.access.redhat.com/ubi8/ubi-minimal:${UBI_MINIMAL_VERSION} | ||
| FROM ${DOCKER_UPSTREAM_REGISTRY}confluentinc/cp-base-java:${DOCKER_TAG} |
There was a problem hiding this comment.
please use new arg/env for the base image name as there are symlinks also added in the Dockerfile
pom.xml
Outdated
| @@ -34,6 +35,8 @@ | |||
| <io.confluent.common-docker.version>8.0.0-0</io.confluent.common-docker.version> | |||
| <!-- Versions--> | |||
| <ubi.image.version>8.10-1154</ubi.image.version> | |||
| <ubi9.image.version>9.5-1736404155</ubi9.image.version> | |||
| <ubi.micro.image.version>8.10-13</ubi.micro.image.version> | |||
There was a problem hiding this comment.
This can be removed as this is not getting used right now.
base-java/pom.xml
Outdated
| <artifactId>dockerfile-maven-plugin</artifactId> | ||
| <configuration> | ||
| <buildArgs> | ||
| <UBI_MINIMAL_VERSION>${ubi.image.version}</UBI_MINIMAL_VERSION> |
There was a problem hiding this comment.
should the variable be ubi9.image.version instead of ubi.image.version
base-java/pom.xml
Outdated
| <image> | ||
| <build> | ||
| <args> | ||
| <UBI_MINIMAL_VERSION>${ubi.image.version}</UBI_MINIMAL_VERSION> |
There was a problem hiding this comment.
should the variable be ubi9.image.version instead of ubi.image.version
| @@ -4,10 +4,10 @@ | |||
| import confluent.docker_utils as utils | |||
There was a problem hiding this comment.
Let's keep this file in base-lite also to make sure base-lite is getting built properly also.
airlock-confluentinc
bot
force-pushed
the
CPBR-1867-ubi9-minimal
branch
from
f1170af to
3d28ec3
Compare
Change Description
a new cp-base image that is built on ubi9-minimal
this image contains only jre and would be used as the base for CP component image
Testing