Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANSIENG-4269] | adding profile_tasks to note time of each task in molecule run #1870

Open
wants to merge 1 commit into
base: 7.9.x
Choose a base branch
from

Conversation

rrbadiani
Copy link
Member

Description

Using profile_tasks to note time taken by each task. Helps analyze where maximum time gets spent to help reduce it.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
  • I have added tests that prove my fix is effective or that my feature works
  • If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@rrbadiani rrbadiani requested a review from a team as a code owner January 2, 2025 06:17
@@ -101,6 +101,9 @@ platforms:
networks:
- name: confluent
provisioner:
config_options:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than adding these config_options, can we do it at a common place something like pre-setup script. And any particular reason to add it from 7.8 and not before?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I felt like 7.8 is pretty recent version so has a lot of new changes in it which is where we might have to look into to optimize the run times. If we did this in older versions also then probably pint merge will be causing some trouble as names of a bunch of tests cases changes in newer versions making it tougher to resolve conflicts.

Yes if we could add this in a pre setup like script that would be easier to manage. I'll check if I can find some way to do that. If that is easily doable then we can go ahead and add this to all older versions as well

@rrbadiani rrbadiani changed the base branch from 7.8.x to 7.9.x January 13, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants