Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OBSDATA-8872]Add maxInterval to kill config and make kill tasks efficient #309

Open
wants to merge 2 commits into
base: 30.0.1-confluent
Choose a base branch
from

Conversation

chetanpatidar26
Copy link

@chetanpatidar26 chetanpatidar26 commented Mar 5, 2025

Description

TL;DR
Kill tasks on cordinators are lagging, causing deep storage to increase rapidly and ingest handoff time spikes. This PR is to fix that.

For more description, please follow

Release note

For tips about how to write a good release note, see Release notes.


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@chetanpatidar26 chetanpatidar26 requested a review from a team as a code owner March 5, 2025 05:14
rbankar7
rbankar7 previously approved these changes Mar 5, 2025
Copy link
Member

@rbankar7 rbankar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants