Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCMSG-1715 updating storage common to add missing jackon-bom dependen… #612

Merged
merged 4 commits into from
Apr 5, 2022

Conversation

kpatelatwork
Copy link
Member

@kpatelatwork kpatelatwork commented Apr 1, 2022

…cy to resolve the jackson 2.13.2 CVE

Problem

Solution

Does this solution apply anywhere else?
  • yes
  • no
If yes, where?

Test Strategy

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

@kpatelatwork kpatelatwork requested a review from a team as a code owner April 1, 2022 04:23
Copy link
Contributor

@BlueEldur BlueEldur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

but have you considered trying to base this off 10.0.x? as this fixes #578 by bringing in hive 2.3.9 right? didn't look into it carefully if 10.1.x is already fixed or what

@kpatelatwork
Copy link
Member Author

kpatelatwork commented Apr 4, 2022

LGTM.

but have you considered trying to base this off 10.0.x? as this fixes #578 by bringing in hive 2.3.9 right? didn't look into it carefully if 10.1.x is already fixed or what

@BlueEldur I tried basing on latest of 10.0.x and the build was failing so I was putting a lot of effort so I thought why not put the effort on latest of 11.1.x as Randall has suggested we use the latest storage common and latest connect-plugins common to get latest CVE fixes.

If the tests are passing do you see any reasons to not upgrade to 11.1.x?

@BlueEldur
Copy link
Contributor

LGTM.
but have you considered trying to base this off 10.0.x? as this fixes #578 by bringing in hive 2.3.9 right? didn't look into it carefully if 10.1.x is already fixed or what

@BlueEldur I tried basing on latest of 10.0.x and the build was failing so I was putting a lot of effort so I thought why not put the effort on latest of 11.1.x as Randall has suggested we use the latest storage common and latest connect-plugins common to get latest CVE fixes.

If the tests are passing do you see any reasons to not upgrade to 11.1.x?

what I meant is merging to 10.0.x. But yeah, no need to go that far back. LGTM

@kpatelatwork kpatelatwork merged commit 923c996 into 10.1.x Apr 5, 2022
@kpatelatwork kpatelatwork deleted the CCMSG-1715 branch April 5, 2022 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants