Use find_package to find SASL2 library #5243
Open
+21
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of relying only on the pkg-config to find the SASL2 library, we should also respect the CMAKE_PREFIX_PATH by using find_package in case sasl2 should be linked statically.
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the SASL2 library detection mechanism in CMake by adding find_package support alongside the existing pkg-config method. This allows the build system to respect CMAKE_PREFIX_PATH for static linking scenarios.
Key changes:
- Added
find_package(SASL2)as the primary detection method before falling back to pkg-config - Restructured the conditional logic to check for SASL2 via find_package first
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tillrohrmann
commented
Nov 13, 2025
Comment on lines
+131
to
+146
| if(PkgConfig_FOUND) | ||
| pkg_check_modules(SASL libsasl2) | ||
| if(SASL_FOUND) | ||
| set(with_sasl_default ON) | ||
| set(SASL_LIBRARIES "-lsasl2") | ||
| else() | ||
| set(with_sasl_default OFF) | ||
| endif() | ||
| else() | ||
| try_compile( | ||
| WITH_SASL_CYRUS_BOOL | ||
| "${CMAKE_CURRENT_BINARY_DIR}/try_compile" | ||
| "${TRYCOMPILE_SRC_DIR}/libsasl2_test.c" | ||
| LINK_LIBRARIES "-lsasl2" | ||
| ) | ||
| if(WITH_SASL_CYRUS_BOOL) | ||
| set(with_sasl_default ON) | ||
| set(SASL_LIBRARIES "-lsasl2") | ||
| else() | ||
| set(with_sasl_default OFF) |
Author
There was a problem hiding this comment.
Not sure whether we still need this if we are using find_package(SASL2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying only on the pkg-config to find the SASL2 library, we should also respect the CMAKE_PREFIX_PATH by using find_package in case sasl2 should be linked statically.