Skip to content

Conversation

@fangnx
Copy link
Member

@fangnx fangnx commented Nov 13, 2025

Move to unit test

@fangnx fangnx requested a review from a team as a code owner November 13, 2025 16:23
Copilot AI review requested due to automatic review settings November 13, 2025 16:23
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a build failure caused by linting issues in the SSL hostname normalization code. The changes address code formatting to comply with the project's linting standards.

Key changes:

  • Reformatted function declaration to fit on a single line
  • Fixed line wrapping and indentation in conditional expressions and function calls

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fangnx fangnx requested a review from pranavrth November 13, 2025 17:26
@justsmth
Copy link

Thanks for posted this PR. This might be the same issue that's causing CI failures in AWS-LC's CI integration tests. For example: https://github.com/aws/aws-lc/actions/runs/19370633236/job/55425386315?pr=2829

/usr/bin/ld: 0154-ssl_hostname_normalize.o: in function `test_hostname_normalize':
/home/runner/work/aws-lc/KAFKA_BUILD_ROOT/librdkafka/tests/0154-ssl_hostname_normalize.c:98:(.text+0x55b): undefined reference to `rd_kafka_ssl_normalize_hostname'
collect2: error: ld returned 1 exit status
make: *** [../mklove/Makefile.base:235: test-runner] Error 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants