Skip to content

Commit

Permalink
Upgrade scala 2.13.x version (#2) (#2)
Browse files Browse the repository at this point in the history
  • Loading branch information
nlou9 authored Aug 13, 2024
1 parent 538d7bc commit 8f7fc6d
Show file tree
Hide file tree
Showing 13 changed files with 202 additions and 197 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -143,13 +143,13 @@ Previous minor versions may work but are supported only on a best effort basis.
To configure Scala version you must call `scala_config(scala_version = "2.xx.xx")` and configure
dependencies by declaring [scala_toolchain](docs/scala_toolchain.md).
For a quick start you can use `scala_repositories()` and `scala_register_toolchains()`, which have
dependency providers configured for `2.11.12`, `2.12.18` and `2.13.12` versions.
dependency providers configured for `2.11.12`, `2.12.18` and `2.13.14` versions.


```starlark
# WORKSPACE
load("@io_bazel_rules_scala//:scala_config.bzl", "scala_config")
scala_config(scala_version = "2.13.12")
scala_config(scala_version = "2.13.14")

load("@rules_proto//proto:repositories.bzl", "rules_proto_dependencies", "rules_proto_toolchains")
rules_proto_dependencies()
Expand Down
4 changes: 3 additions & 1 deletion dt_patches/dt_patch_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ run_test_local test_compiler_patch 2.13.8
run_test_local test_compiler_patch 2.13.10
run_test_local test_compiler_patch 2.13.11
run_test_local test_compiler_patch 2.13.12
run_test_local test_compiler_patch 2.13.14

run_test_local test_compiler_srcjar_error 2.12.11
run_test_local test_compiler_srcjar_error 2.12.12
Expand All @@ -128,4 +129,5 @@ run_test_local test_compiler_srcjar_nonhermetic 2.12.17
run_test_local test_compiler_srcjar_nonhermetic 2.12.18

run_test_local test_compiler_srcjar_nonhermetic 2.13.11
run_test_local test_compiler_srcjar_nonhermetic 2.13.12
run_test_local test_compiler_srcjar_nonhermetic 2.13.12
run_test_local test_compiler_srcjar_nonhermetic 2.13.14
3 changes: 3 additions & 0 deletions dt_patches/test_dt_patches_user_srcjar/WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ srcjars_by_version = {
"2.13.12": {
"url": "https://repo1.maven.org/maven2/org/scala-lang/scala-compiler/2.13.12/scala-compiler-2.13.12-sources.jar?foo",
},
"2.13.14": {
"url": "https://repo1.maven.org/maven2/org/scala-lang/scala-compiler/2.13.14/scala-compiler-2.13.14-sources.jar?foo",
},
}

rules_scala_setup(scala_compiler_srcjar = srcjars_by_version[SCALA_VERSION])
Expand Down
2 changes: 1 addition & 1 deletion examples/crossbuild/1_single/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ scala_library(
scala_test(
name = "test213",
srcs = ["test.scala"],
scala_version = "2.13.12",
scala_version = "2.13.14",
)

# This one will be compiled by 3.3 compiler (the default one):
Expand Down
2 changes: 1 addition & 1 deletion examples/crossbuild/2_deps/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ scala_binary(
name = "bin213",
srcs = ["bin.scala"], # compiled with 2.13 (as per `scala_version`)
main_class = "C",
scala_version = "2.13.12",
scala_version = "2.13.14",
deps = [
":lib", # compiled 2.13 (as per `scala_version`)
":lib211", # compiled with 2.11 (that target overrides version)
Expand Down
2 changes: 1 addition & 1 deletion examples/crossbuild/3_select/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ scala_binary(
name = "bin2",
srcs = ["bin.scala"],
main_class = "B",
scala_version = "2.13.12",
scala_version = "2.13.14",
deps = [":lib"],
)

Expand Down
2 changes: 1 addition & 1 deletion examples/crossbuild/WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ scala_config(
scala_version = "3.3.1",
scala_versions = [
"2.11.12",
"2.13.12",
"2.13.14",
"3.3.1",
],
)
Expand Down
2 changes: 1 addition & 1 deletion examples/semanticdb/WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ local_repository(

load("@io_bazel_rules_scala//:scala_config.bzl", "scala_config")

scala_config(scala_version = "2.13.12")
scala_config(scala_version = "2.13.14")

load(
"@io_bazel_rules_scala//scala:scala.bzl",
Expand Down
2 changes: 1 addition & 1 deletion test/shell/test_scala_config.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ test_classpath_contains_2_12() {

test_classpath_contains_2_13() {
bazel aquery 'mnemonic("Javac", //src/java/io/bazel/rulesscala/scalac:scalac)' \
--repo_env=SCALA_VERSION=2.13.12 \
--repo_env=SCALA_VERSION=2.13.14 \
| grep scala-library-2.13
}

Expand Down
2 changes: 1 addition & 1 deletion test_cross_build/WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ scala_config(
scala_versions = [
"2.11.12",
"2.12.18",
"2.13.12",
"2.13.14",
"3.1.0",
"3.2.1",
"3.3.1",
Expand Down
4 changes: 2 additions & 2 deletions test_cross_build/scalafmt/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ scalafmt_scala_library(
srcs = ["unformatted/unformatted-library2.scala"],
config = ":scala2-conf",
format = True,
scala_version = "2.13.12",
scala_version = "2.13.14",
)

scalafmt_scala_library(
name = "formatted-library2",
srcs = ["formatted/formatted-library2.scala"],
config = ":scala2-conf",
format = True,
scala_version = "2.13.12",
scala_version = "2.13.14",
)

scalafmt_scala_library(
Expand Down
2 changes: 1 addition & 1 deletion test_version.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -e

scala_2_11_version="2.11.12"
scala_2_12_version="2.12.18"
scala_2_13_version="2.13.12"
scala_2_13_version="2.13.14"

SCALA_VERSION_DEFAULT=$scala_2_11_version

Expand Down
Loading

0 comments on commit 8f7fc6d

Please sign in to comment.