-
Notifications
You must be signed in to change notification settings - Fork 44
Refresh RPM lockfiles (main) #2934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
red-hat-konflux
wants to merge
1
commit into
main
Choose a base branch
from
konflux/mintmaker/main-main/lock-file-maintenance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refresh RPM lockfiles (main) #2934
red-hat-konflux
wants to merge
1
commit into
main
from
konflux/mintmaker/main-main/lock-file-maintenance
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2900e2e to
8876234
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
356816b to
3decc66
Compare
Member
|
This is bad I think, the ubi-9-for-aarch64-appstream-rpms is changed to ubi-9-appstream-rpms, which I think will cause conforma failures about allowed repoids. |
8a499ae to
c101f78
Compare
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
c101f78 to
1be5f7c
Compare
simonbaird
added a commit
to simonbaird/conforma-cli
that referenced
this pull request
Oct 9, 2025
IIUC this file is only used by Mintmaker. It was added in EC-1244 to prevent Mintmaker from failing. More specifically it's used by "rpm-lockfile-prototype" which IIUC Mintmaker is using to freshen rpm lockfiles. For this change I'm hoping to prevent the "good" repoids (such as "ubi-9-for-aarch64-baseos-rpms" with "bad" repoids (such as "ubi-9-baseos-rpms") in our rpms.in.lock file, in PRs such as conforma#2934. The "bad" repoids can produce Conforma violations, since the shorter repoids are not in the allowed repo list, which is visible here: https://github.com/release-engineering/rhtap-ec-policy/blob/main/data/known_rpm_repositories.yml. See also the hack/update-rpm-lock.sh script, which is our own custom script we've used in the past for updating the rpm lockfile.
simonbaird
added a commit
to simonbaird/conforma-cli
that referenced
this pull request
Oct 9, 2025
IIUC this file is used by Mintmaker. It was added in EC-1244 to prevent Mintmaker from failing. More specifically it's used by `rpm-lockfile-prototype` which IIUC Mintmaker is using to freshen rpm lockfiles. For this change I'm hoping to prevent the "good" repoids (such as "ubi-9-for-aarch64-baseos-rpms" from being converted to "bad" repoids (such as "ubi-9-baseos-rpms") in our `rpms.lock.yaml file`, in PRs such as conforma#2934. The "bad" repoids can produce Conforma violations, since the shorter repoids are not in the allowed repo list, visible [here](https://github.com/release-engineering/rhtap-ec-policy/blob/main/data/known_rpm_repositories.yml). See also the `hack/update-rpm-lock.sh` script in this repo, which is our own custom script we've used in the past for updating the rpm lockfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
Warning
Some dependencies could not be looked up. Check the warning logs for more information.
🔧 This Pull Request updates lock files to use the latest dependency versions.
Configuration
📅 Schedule: Branch creation - "before 5am" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.