[WIP] Implement the auditor-server application layer #193
Conversation
masomel
force-pushed
the
auditor-server-cli
branch
from
7117f50
to
be900a4
Compare
utils/binutils/encoding.go
Outdated
| } | ||
|
|
||
| // MarshalSTRToFile serializes the given STR to the given path. | ||
| func MarshalSTRToFile(str *protocol.DirSTR, path string) { |
There was a problem hiding this comment.
Definitely. This particular function is just for the test implementation, but in implementing the auditor, having a persistent storage backend is becoming more and more necessary. We should get back to implementing that soon.
masomel
force-pushed
the
auditor-server-cli
branch
2 times, most recently
from
1ab0a2a
to
df1762c
Compare
masomel
force-pushed
the
auditor-server-cli
branch
from
94beaec
to
7466552
Compare
utils/binutils/logger.go
Outdated
| @@ -0,0 +1,134 @@ | |||
| package binutils | |||
There was a problem hiding this comment.
We already have application/logger.go.
There was a problem hiding this comment.
Ugh, thanks for catching that. I thought I removed the binutils package when I rebased.
…into auditor-server-cli
application/encoding.go
Outdated
| @@ -77,8 +77,12 @@ func UnmarshalResponse(t int, msg []byte) *protocol.Response { | |||
| Error: res.Error, | |||
| } | |||
| if err := response.Validate(); err != nil { | |||
| return &protocol.Response{ | |||
| Error: protocol.ErrMalformedMessage, | |||
| // we don't want to return an ErrMalformedMessage | |||
There was a problem hiding this comment.
I think this is covered in https://github.com/coniks-sys/coniks-go/blob/master/protocol/message.go#L272
There was a problem hiding this comment.
Yes, but the problem is that this function was still returning an ErrMalformedMessage even if the error is in errors. In other words, because Validate() in message.go returns msg.Error, which gives err == nil after Validate() returns, the return &protocol.Response{Error: protocol.ErrMalformedMessage } statement was always being called, even when the msg.Error was in errors.
There was a problem hiding this comment.
I see. I gave it a try in https://github.com/coniks-sys/coniks-go/compare/unmarshalling. If it's ok, feel free to merge to this branch.
There was a problem hiding this comment.
Those changes looks good to me. Thank you! I also like that you re-wrote the test cases. I'll merge this branch when I get a chance.
Part of #151