Skip to content

feat(domain_of): implement attributes of union and intersect domains#1547

Draft
ca1umac wants to merge 12 commits intomainfrom
1527-fix-attributes-of-union-and-intersect-domains
Draft

feat(domain_of): implement attributes of union and intersect domains#1547
ca1umac wants to merge 12 commits intomainfrom
1527-fix-attributes-of-union-and-intersect-domains

Conversation

@ca1umac
Copy link
Contributor

@ca1umac ca1umac commented Feb 21, 2026

Description

Currently set attributes for union and intersect expressions are set to default. This is unbounded. In reality, you may be able to infer bounds. This PR updates conjure-cp-core::ast::expressions::Expression::domain_of.

Related issues

Key changes

  • calculate tighter domain attributes for Union and Intersect

How to test/review

TBD

@ca1umac ca1umac self-assigned this Feb 21, 2026
@ca1umac ca1umac linked an issue Feb 21, 2026 that may be closed by this pull request
@conjure-bot
Copy link

conjure-bot bot commented Feb 21, 2026

Documentation Coverage

Report: https://conjure-cp.github.io/conjure-oxide-reports/pr/1547/coverage-docs/index.html

This PR: 43.48% documented, 4.97% with examples (8/70/161)
Main: 43.48% documented, 4.97% with examples (8/70/161)
Delta: docs +0.00 pp, examples +0.00 pp

@ca1umac ca1umac changed the title 1527 fix attributes of union and intersect domains feat(domain_of): implement attributes of union and intersect domains Feb 21, 2026
@conjure-bot
Copy link

conjure-bot bot commented Feb 21, 2026

Code Coverage

Report: https://conjure-cp.github.io/conjure-oxide-reports/pr/1547/coverage-code/index.html
Diff report: https://conjure-cp.github.io/conjure-oxide-reports/pr/1547/coverage-code/diff-coverage.html

This PR: 72.95% lines (16621/22785)
Diff: 0.00% lines (0/18 measured; 22 changed)
Main: 73.64% lines (16621/22572)
Delta vs main: -0.69 pp

@ca1umac
Copy link
Contributor Author

ca1umac commented Mar 12, 2026

Even though the tests here pass, it is currently blocked on #1630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Attributes of Union and Intersect domains

1 participant