feat(domain_of): implement attributes of union and intersect domains#1547
Draft
feat(domain_of): implement attributes of union and intersect domains#1547
Conversation
Documentation CoverageReport: https://conjure-cp.github.io/conjure-oxide-reports/pr/1547/coverage-docs/index.html This PR: 43.48% documented, 4.97% with examples (8/70/161) |
Code CoverageReport: https://conjure-cp.github.io/conjure-oxide-reports/pr/1547/coverage-code/index.html This PR: 72.95% lines (16621/22785) |
…github.com:conjure-cp/conjure-oxide into 1527-fix-attributes-of-union-and-intersect-domains
Contributor
Author
|
Even though the tests here pass, it is currently blocked on #1630 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently set attributes for union and intersect expressions are set to default. This is unbounded. In reality, you may be able to infer bounds. This PR updates
conjure-cp-core::ast::expressions::Expression::domain_of.Related issues
Key changes
How to test/review
TBD