Fix nightly build

[niklasdewally]

In recent versions of the nightly / beta compilers, the use of linkme causes linker errors. (dtolnay/linkme#94) This is due to the new linker set as default in these versions.

Add linker flags to nightly builds to revert to the old linker behaviour.

See:

• Disable rust-lld in CI dtolnay/linkme#88
• https://blog.rust-lang.org/2024/05/17/enabling-rust-lld-on-linux.html

[ozgurakgun]

Thanks for looking into this @niklasdewally. It doesn't look like there is a trivial fix at the moment, should we temporarily disable the nightly ubuntu test I wonder?

[niklasdewally]

Thanks for looking into this @niklasdewally. It doesn't look like there is a trivial fix at the moment, should we temporarily disable the nightly ubuntu test I wonder?

The flags I put in this commit (and given in the rust article above) work -- the issue at the moment is .cargo/config.toml syntax and how to enable it for the build through that. Setting RUSTFLAGS=-Clink-arg=-Wl,-z,nostart-stop-gc when building nightly (and communicating this in the docs) would work as a basic fix for this.

For CI, the fix done in dtolnay/linkme#88 would work for us (i.e. just setting RUSTFLAGS in the CI script) -- however, I think that we should also fix it for non-CI builds without manual intervention -- i.e. in .cargo/config.toml, or in build.rs.

[niklasdewally]

I am in full-time work currently so probably won't get to this until Sunday - if anyone wants to take over the PR, feel free. A temporary solution would probably be fine, considering that linkme will eventually fix this upstream.

[niklasdewally]

@ozgurakgun

[ozgurakgun]

Thanks! This looks good! Hope you are enjoying the summer job.