Skip to content

Commit

Permalink
Update client.go
Browse files Browse the repository at this point in the history
After some research it seems to be the right way to do this so I removed the HOTFIX comment.
  • Loading branch information
matthieugusmini authored Feb 16, 2023
1 parent b10d68c commit 8e43c0d
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions client.go
Original file line number Diff line number Diff line change
Expand Up @@ -247,9 +247,6 @@ func (c *Client) requestData(database, table, version, gtid string) (<-chan Even
func (c *Client) handleEvents(data chan<- Event) error {
var readSchema bool
scanner := bufio.NewScanner(c.conn)
// HOTFIX: Replace by a `bufio.Reader` instead since it seems to be the
// preferred method.
// See https://pkg.go.dev/bufio#Scanner
buf := make([]byte, 0, MaxScanTokenSize)
scanner.Buffer(buf, MaxScanTokenSize)
for scanner.Scan() {
Expand Down

0 comments on commit 8e43c0d

Please sign in to comment.