Change chars for MultiSelect items
#275
Conversation
|
IMHO, it doesn't look good. |
|
Which new rendering do you think is the worst? The new VSCode's terminal rendering is questionable. |
|
The same rendering is also used for Mac and Linux, where the X emoji does not look good. |
|
What about '☑' '☒' or '✔' '✘' '☓' |
| @@ -71,8 +71,8 @@ impl Default for ColorfulTheme { | |||
| inactive_item_style: Style::new().for_stderr(), | |||
| active_item_prefix: style("❯".to_string()).for_stderr().green(), | |||
| inactive_item_prefix: style(" ".to_string()).for_stderr(), | |||
| checked_item_prefix: style("✔".to_string()).for_stderr().green(), | |||
| unchecked_item_prefix: style("✔".to_string()).for_stderr().black(), | |||
There was a problem hiding this comment.
Try ◌ but don't change the colors.
There was a problem hiding this comment.
I checked locally and this looks too small on many fonts. I have tried many other characters; most are too small or too wide. ⬚ looks the best. So, let's use that, and set the color to magenta
There was a problem hiding this comment.
Ok, I've checked locally too and it's good. Except conhost doesn't know this symbol but renders color correctly.
|
'◌' looks good. windows term: conhost: vscode: black is invisible both in windows term and in conhost.exe: |
|
Linting fails because of: #209 |
|
Feel free to fix it in this PR |
|
Linting and changelog fixed. |
|
Windows Terminal, a widely used terminal emulator for some reason does not support coloring for '✔' char.
'✔️' and '❌' may be used instead. They work down to the previous Windows terminal emulator:
conhost.exe.Before:
Windows Terminal
As you can see, selected and unselected items are indistinguishable.
conhost.exeSurprisingly, the old windows emulator is better than new one.
VSCode
After:
Windows Terminal
conhost.exeVSCode