Add to the icm schema a field to indicate if the icm should be ignored #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables a path to deprecation. Today, scanners depend on this file primarilly for the list of content_sets. In the future, with konflux-ci, we want third-party scanners to refer to the dnf database for a more precise mapping of which rpms come from which content_sets. The idea here is that image providers can still publish an icm file, but if the from_dnf_hint is set to true, then scanners are supposed to ignore the icm file and trust the dnf database instead. Scanners that haven't been ported to the new method will continue to work in the current imprecise way until they adapt to scanning the dnf database. Signed-off-by: Ralph Bean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables a path to deprecation.
Today, scanners depend on this file primarilly for the list of content_sets.
In the future, with konflux-ci, we want third-party scanners to refer to the dnf database for a more precise mapping of which rpms come from which content_sets.
The idea here is that image providers can still publish an icm file, but if the from_dnf_hint is set to true, then scanners are supposed to ignore the icm file and trust the dnf database instead. Scanners that haven't been ported to the new method will continue to work in the current imprecise way until they adapt to scanning the dnf database.
Maintainers will complete the following section