integration tests minor improvements #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskultety
reviewed
Jan 10, 2025
a-ovchinnikov
approved these changes
Jan 10, 2025
`yarn` and `yarn classic` are used interchangeably for cachi2 requests -> only `yarn` is among supported package managers Our functionality for integration tests skips those not affected by certain package manager. Since `yarn classic` is not a valid name as a supported package manager, integration tests were never skipped, becuase these are marked as `test_yarn_classic...` in a separate module. Signed-off-by: Michal Šoltis <[email protected]>
Currently, the `nox -s generate-test-data` runs only on tests marked as e2e because of passing the `PYTEST_ADDOPTS` env variable. This was unfortunately implemented based on my wrong assumption that only e2e tests with docker builds generate SBOM. Fix the command and run all integration tests when someone wants to regenerate test data based on their changes. Signed-off-by: Michal Šoltis <[email protected]>
Signed-off-by: Michal Šoltis <[email protected]>
Drop both tests from `test_bundler_packages` function and keep them as e2e tests in `test_e2e_bundler`: https://github.com/containerbuildsystem/cachi2/blob/7557f2c6ab01523de5a544e2ab34e4134b976069/tests/integration/test_bundler.py#L106 https://github.com/containerbuildsystem/cachi2/blob/7557f2c6ab01523de5a544e2ab34e4134b976069/tests/integration/test_bundler.py#L121 Signed-off-by: Michal Šoltis <[email protected]>
slimreaper35
force-pushed
the
tests
branch
2 times, most recently
from
cd5cfcd to
85badba
Compare
eskultety
approved these changes
Jan 16, 2025
Merged
via the queue into
containerbuildsystem:main
with commit Jan 16, 2025
03b433f
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainers will complete the following section
Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:
/ok-to-test(as is the standard for Pipelines as Code)