Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix symbolic link panic #11

Merged
merged 1 commit into from
May 20, 2020

Conversation

mikebrow
Copy link
Member

@mikebrow mikebrow commented May 15, 2020

avoids panic when running into a symlink by ignoring the symlink needed for
https://github.com/containerd/cri/blob/master/test/e2e

before:

ltag -t "../project/script/validate/template" --excludes "vendor" --check -v
panic: read test/e2e: is a directory

goroutine 1 [running]:
main.main()
	/home/mike/go/src/github.com/kunalkushwaha/ltag/main.go:99 +0xa95

after fix:

ltag -t "../project/script/validate/template" --excludes "vendor" --check -v
_output/containerd

See: https://golang.org/pkg/path/filepath/ "Walk does not follow symbolic links." possibly fixed in 1.14.3 golang/go@7d27e87

Signed-off-by: Mike Brown [email protected]

@mikebrow
Copy link
Member Author

needed for merging containerd/cri into containerd.. so we don't have to skip test/ to run header check

containerd/cri#1479

Signed-off-by: Mike Brown <[email protected]>
@mikebrow mikebrow force-pushed the fix-symbolic-link-error branch from 8feb317 to 5a99b30 Compare May 15, 2020 13:47
@kunalkushwaha kunalkushwaha merged commit 1f92d0b into containerd:master May 20, 2020
@kunalkushwaha
Copy link
Collaborator

Thank you @mikebrow for PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants