fix: restart lark loguri cause start failed #3219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Howie <[email protected]>
|
ref: #1274 |
|
Can we have a test? |
fahedouch
reviewed
Jul 25, 2024
| @@ -117,6 +117,8 @@ func NewTask(ctx context.Context, client *containerd.Client, container container | |||
| return nil, err | |||
| } | |||
| ioCreator = cio.LogURI(u) | |||
| } else if flagD && logURI == "" { | |||
There was a problem hiding this comment.
Could you please add comment for this specific case!
|
Hey @Howie59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the container was not created by nerdctl, by default logURI args is empty.
nerdctl/pkg/cmd/container/create.go
Line 178 in d273fd2
when exec nerdctl restart, it will use logURI start log path, then will cause
FATA[0000] 1 errors: failed to start binary process with cmdArgs []: exec: no commandnerdctl/pkg/cioutil/container_io.go
Line 179 in d273fd2