[WIP] Add support for writing to ptys #3591
Conversation
|
Failure is unrelated. |
| defer pty.Close() | ||
| defer tty.Close() | ||
|
|
||
| for _, writer := range gc.ptyWriters { |
There was a problem hiding this comment.
Shouldn't we use errgroup to wait for the routines?
There was a problem hiding this comment.
Yes indeed.
Will update.
There was a problem hiding this comment.
Reverting to draft for the time being - being abroad I may not have time to look into this immediately.
Thanks @AkihiroSuda .
apostasie
changed the title
Signed-off-by: apostasie <[email protected]>
| }() | ||
| } | ||
|
|
||
| defer func() { |
There was a problem hiding this comment.
| defer func() { | |
| defer func() { | |
| // Best effort. |
There was a problem hiding this comment.
this may help when debugging issues ;)
There was a problem hiding this comment.
Thanks for the review @fahedouch
this is not ready though - I left it half assed a little while back, but will get it proper soon!
| @@ -105,8 +107,18 @@ func (gc *GenericCommand) Run(expect *Expected) { | |||
| iCmdCmd.Stdin = tty | |||
| iCmdCmd.Stdout = tty | |||
| iCmdCmd.Stderr = tty | |||
| defer pty.Close() | |||
| defer tty.Close() | |||
There was a problem hiding this comment.
please don't move defer tty.Close()
There was a problem hiding this comment.
not mandatory but you can just defer closing the tty before the goroutines loop
This is the next step in removing
unbufferfrom our testing, adding the ability to write to stdin with ptys.