Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable more tests to run on windows #3624

Merged
merged 7 commits into from
Nov 4, 2024
Merged

Enable more tests to run on windows #3624

merged 7 commits into from
Nov 4, 2024

Conversation

apostasie
Copy link
Contributor

@apostasie apostasie commented Oct 31, 2024 •
edited
Loading

On top of #3631 and #3632.

This PR enables tests on Windows, or annotate them to indicate why they can't run there.

The following have been reviewed:

  • root
  • volume
  • system
  • network
  • namespace
  • issues
  • ipfs
  • internal
  • inspect
  • apparmor
  • completion

The following need to be reviewed more thoroughly:

@apostasie apostasie force-pushed the series-13 branch 3 times, most recently from 54310d4 to ba1ecb9 Compare October 31, 2024 13:18
@apostasie apostasie force-pushed the series-13 branch 2 times, most recently from b7e83b3 to 6c35eef Compare November 2, 2024 21:36
@apostasie apostasie marked this pull request as ready for review November 2, 2024 22:55
@apostasie apostasie changed the title [WIP] Enable more tests to run on windows Enable more tests to run on windows Nov 2, 2024
@AkihiroSuda AkihiroSuda added area/ci e.g., CI failure platform/Windows/Non-WSL2 Microsoft Windows (non-WSL2) labels Nov 4, 2024
AkihiroSuda
AkihiroSuda approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit f12f7fe into containerd:main Nov 4, 2024
30 checks passed
@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Nov 4, 2024
@AkihiroSuda AkihiroSuda mentioned this pull request Nov 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
area/ci e.g., CI failure platform/Windows/Non-WSL2 Microsoft Windows (non-WSL2)
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@apostasie @AkihiroSuda