Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable IPv6 on compose networks where enable_ipv6 is true #3686

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

darktohka
Copy link

There is a compose feature called enable_ipv6 that can be set on a network.

When this is currently set on a compose network, it has no effect. Compose does let us know that the EnableIPv6 flag is ignored, though.

However, nerdctl network create does support IPv6, it can be set using the --ipv6 flag. When the --ipv6 flag is set, IPv6 IPAM is added just like IPv4 IPAM to the network. However, when --ipv6 is not set, the IPv6 IPAM is ignored and only the IPv4 settings are added.

We should add support for enable_ipv6. This PR aims just to do that.

Please note that this is not enough for compose to support IPv6... see issue #3637. I'm not yet familiar enough with the codebase to add such a feature. But this should allow manual configuration.

Added two tests:

  • one test to test enable_ipv6 true, the IPv6 subnet should stay in the IPAM configuration after creation
  • one test to test enable_ipv6 false, the IPv6 subnet is filtered out of the IPAM configuration after creation and only IPv4 remains

@darktohka
Copy link
Author

Seems like the second test: "test to test enable_ipv6 false, the IPv6 subnet is filtered out of the IPAM configuration after creation and only IPv4 remains" fails on the Docker integration test.

Should we remove this test and only test if enable_ipv6: true works fine?

@fahedouch
Copy link
Member

Seems like the second test: "test to test enable_ipv6 false, the IPv6 subnet is filtered out of the IPAM configuration after creation and only IPv4 remains" fails on the Docker integration test.

Should we remove this test and only test if enable_ipv6: true works fine?

I think we need to figure out why nerdctl runtime do not consider enable_ipv6 false, it may point to an underlying problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants