Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update:fix update pids-limit=0 error #3781

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ningmingxiao
Copy link
Contributor

@ningmingxiao ningmingxiao commented Dec 19, 2024

when try nerdctl -n k8s.io update --cpuset-cpus 0-2 ffe
this code

if spec.Linux.Resources.Pids == nil {
spec.Linux.Resources.Pids = &runtimespec.LinuxPids{}
}

will make spec.Linux.Resources.Pids =0 it will not work on rust-shim(will cause rshim set pidlimit=0 goshim works well.).
https://github.com/containerd/rust-extensions
will cause

./nerdctl  -n k8s.io  exec  ffe  date
FATA[0000] Others("Other: OCI runtime exec failed: exec failed: unable to start container process: read init-p: connection reset by peer"): unknown

runc log 
runtime/cgo: pthread_create failed: Resource temporarily unavailable

SIGABRT: abort

PC=0x7f128ec969cf m=0 sigcode=18446744073709551610

@ningmingxiao ningmingxiao force-pushed the fix_update branch 3 times, most recently from ce0b396 to 857501d Compare December 19, 2024 12:21
@ningmingxiao ningmingxiao changed the title update:fix update error update:fix update pids-limit=0 error Dec 19, 2024
@ningmingxiao
Copy link
Contributor Author

fix: #3784

@ningmingxiao
Copy link
Contributor Author

@AkihiroSuda can you review this pr ,thank you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant