Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nerdctl build --add-host option support #3786

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add nerdctl build --add-host option support #3786

wants to merge 1 commit into from
+62 −1

Conversation

austinvazquez
Copy link
Member

This change adds support for image build --add-host option to enable custom host-to-IP mappings.

@austinvazquez austinvazquez mentioned this pull request Dec 23, 2024
Open
chews93319
chews93319 approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@chews93319 chews93319 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nit/qq: Will the image build --add-host need to handle the special 'host-gateway' string?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderbirju coderbirju coderbirju approved these changes

@chews93319 chews93319 chews93319 approved these changes

@pendo324 pendo324 pendo324 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@austinvazquez @pendo324 @chews93319 @coderbirju