-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
darwin build #732
base: main
Are you sure you want to change the base?
darwin build #732
Conversation
8cb1198
to
85b9c03
Compare
.github/workflows/test.yml
Outdated
@@ -108,7 +114,24 @@ jobs: | |||
- uses: actions/checkout@v2 | |||
with: | |||
fetch-depth: 1 | |||
- name: OSXCross for CGO Support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about legal status of this.
Better not to use it, probably.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can just compile it on macOS instances of GHA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about legal status of this.
Better not to use it, probably.
indeed..
We can just compile it on macOS instances of GHA
I see.
if we don't have to publish the binaries via make artifacts
over cross compiling on a Linux host, it should be okay.
I will seek a way to handle this.
This has to be marked as an experimental feature in |
okay. I'll also prepare documents to address the above concerns. |
This commit fixes issues building darwin binaries (darwin/amd64,arm64). It also adds unit tests and lint test on CI. cgo should be enabled for darwin build because dependent package (moby/sys/mountinfo) failed to lookup mounted volume, thus nerdctl fails to unmount volumes. Signed-off-by: Hajime Tazaki <[email protected]>
85b9c03
to
ba53cb6
Compare
@thehajime curious if this is still something people want to pursue. |
It is still nice to support Darwin hosts, especially for Wasm and VM runtimes |
Closes containerd#732
Closes containerd#732 Signed-off-by: Marat Radchenko <[email protected]>
Closes containerd#732 Signed-off-by: Marat Radchenko <[email protected]>
Closes containerd#732 Signed-off-by: Marat Radchenko <[email protected]>
See #3763 for a new attempt. |
Closes containerd#732 Signed-off-by: Marat Radchenko <[email protected]>
This is yet another mac build PR. darwin support of containerd is still underway, but would like to ask your opnions.
There are several notes on the current status:
nerdctl run
with--net=none
option; with --net options, it won't work. On arm64/darwin, nerdctl itself works, but there is no available runtime.This might be a duplicate of #645