Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwin build #732

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

thehajime
Copy link

This is yet another mac build PR. darwin support of containerd is still underway, but would like to ask your opnions.

There are several notes on the current status:

This might be a duplicate of #645

@thehajime thehajime marked this pull request as draft January 25, 2022 23:24
@thehajime thehajime force-pushed the feature-darwin-build branch from 8cb1198 to 85b9c03 Compare January 26, 2022 00:24
@thehajime thehajime changed the title darwin issue darwin build Jan 26, 2022
@@ -108,7 +114,24 @@ jobs:
- uses: actions/checkout@v2
with:
fetch-depth: 1
- name: OSXCross for CGO Support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about legal status of this.
Better not to use it, probably.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just compile it on macOS instances of GHA

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about legal status of this.
Better not to use it, probably.

indeed..

We can just compile it on macOS instances of GHA

I see.
if we don't have to publish the binaries via make artifacts over cross compiling on a Linux host, it should be okay.

I will seek a way to handle this.

@AkihiroSuda
Copy link
Member

This has to be marked as an experimental feature in docs/experimental.md.
We also need a well written document, perhaps in docs/darwin.md, or docs/lkl.md.
Differences from lima nerdctl should be explained in the docs, too.

@thehajime
Copy link
Author

This has to be marked as an experimental feature in docs/experimental.md.
We also need a well written document, perhaps in docs/darwin.md, or docs/lkl.md.
Differences from lima nerdctl should be explained in the docs, too.

okay. I'll also prepare documents to address the above concerns.

@AkihiroSuda AkihiroSuda mentioned this pull request Jan 31, 2022
This commit fixes issues building darwin binaries (darwin/amd64,arm64).  It
also adds unit tests and lint test on CI.

cgo should be enabled for darwin build because dependent package
(moby/sys/mountinfo) failed to lookup mounted volume, thus nerdctl fails
to unmount volumes.

Signed-off-by: Hajime Tazaki <[email protected]>
@thehajime thehajime force-pushed the feature-darwin-build branch from 85b9c03 to ba53cb6 Compare February 1, 2022 00:13
@apostasie
Copy link
Contributor

@thehajime curious if this is still something people want to pursue.

@AkihiroSuda
Copy link
Member

It is still nice to support Darwin hosts, especially for Wasm and VM runtimes

slonopotamus added a commit to slonopotamus/nerdctl that referenced this pull request Dec 15, 2024
@slonopotamus slonopotamus mentioned this pull request Dec 15, 2024
slonopotamus added a commit to slonopotamus/nerdctl that referenced this pull request Dec 15, 2024
Closes containerd#732

Signed-off-by: Marat Radchenko <[email protected]>
slonopotamus added a commit to slonopotamus/nerdctl that referenced this pull request Dec 15, 2024
Closes containerd#732

Signed-off-by: Marat Radchenko <[email protected]>
slonopotamus added a commit to slonopotamus/nerdctl that referenced this pull request Dec 15, 2024
Closes containerd#732

Signed-off-by: Marat Radchenko <[email protected]>
@slonopotamus
Copy link

See #3763 for a new attempt.

slonopotamus added a commit to slonopotamus/nerdctl that referenced this pull request Dec 15, 2024
Closes containerd#732

Signed-off-by: Marat Radchenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants